From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v7 7/8] doc: add documentation for windows
Date: Tue, 02 Apr 2019 01:22:06 +0200
Message-ID: <111013680.KhI2ai8QQM@xps>
References: <20190306041634.12976-1-anand.rawat@intel.com>
 <20190328232451.16988-1-anand.rawat@intel.com>
 <20190328232451.16988-8-anand.rawat@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com,
 jeffrey.b.shaw@intel.com, bruce.richardson@intel.com,
 harini.ramakrishnan@microsoft.com
To: Anand Rawat <anand.rawat@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 18ED22B99
 for <dev@dpdk.org>; Tue,  2 Apr 2019 01:22:10 +0200 (CEST)
In-Reply-To: <20190328232451.16988-8-anand.rawat@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

29/03/2019 00:24, Anand Rawat:
> Added documentation to build helloworld example
> on windows using meson and clang. Updated the
> maintainers list to include windows maintainers.
[...]
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> +Windows support
> +M: Harini Ramakrishnan <harini.ramakrishnan@microsoft.com>
> +M: Omar Cardona <ocardona@microsoft.com>
> +M: Anand Rawat <anand.rawat@intel.com>
> +M: Ranjit Menon <ranjit.menon@intel.com>
> +F: lib/librte_eal/windows/

This change should be in the first patch (when introducing eal/windows).
In this doc patch, you should add
	F: doc/guides/windows_gsg/

[...]
> +The DPDK and its applications require the Clang-LLVM* C compiler and MSVC* linker.
> +The Meson* Build system is used to prepare the sources for compilation with the Ninja backend.
> +
> +\*Other names and brands may be claimed as the property of others.

This sentence looks weird. What does it mean?

[...]
> +Download and install the clang compiler from `LLVM* website <http://releases.llvm.org/download.html>`_.

Why is there an asterisk after LLVM?

[...]
> +Download and install the Build Tools for Visual Studio to link and build the files on windows, from `Microsoft* website <https://visualstudio.microsoft.com/downloads>`_.
> +When installing build tools, select the "Visual C++ build tools" option and ensure the Windows SDK is selected.

Please try to limit the line length.
We are supposed to not exceed 80-chars if possible.
The best is to wrap lines logically (as in code)
after a comma or a point, etc.

[...]
> +    cd C:\Users\me\dpdk\build
> +    helloworld.exe
> +    hello from core 1
> +    hello from core 3
> +    hello from core 0
> +    hello from core 2

That's definitely a good goal for release 19.05!

> +Limitations
> +===========
> +
> +DPDK for Windows is currently a work in progress. Not all DPDK source files
> +compile. Support is being added in pieces so as to limit the overall scope
> +of any individual patch series. The goal is to be able to run any DPDK
> +application natively on Windows.

Yes