From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] doc: announce API/ABI changes for vhost Date: Mon, 13 Feb 2017 19:02:56 +0100 Message-ID: <11273851.Pnx70jxc9N@xps13> References: <1485176682-12379-1-git-send-email-yuanhan.liu@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Maxime Coquelin , John McNamara , Ben Walker To: Yuanhan Liu Return-path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id D36B62C4B for ; Mon, 13 Feb 2017 19:02:57 +0100 (CET) Received: by mail-wm0-f42.google.com with SMTP id 196so8227250wmm.1 for ; Mon, 13 Feb 2017 10:02:57 -0800 (PST) In-Reply-To: <1485176682-12379-1-git-send-email-yuanhan.liu@linux.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-01-23 21:04, Yuanhan Liu: > I made a vhost ABI/API refactoring at v16.04, meant to avoid such issue > forever. Well, apparently, I lied. > > People are looking for more vhost-user options now days, other than > vhost-user net only. For example, SPDK (Storage Performance Development > Kit) are looking for chance of vhost-user SCSI and vhost-user block. > > Apparently, they also need a vhost-user backend, while DPDK already > has a (mature enough) backend, they don't want to implement it again > from scratch. They want to leverage the one DPDK provides. > > However, the last refactoring hasn't done that right, at least it's > not friendly for extending vhost-user to add more devices support. > For example, different virtio devices has its own feature set, while > APIs like rte_vhost_feature_disable(feature_mask) have no option to > tell the device type. Thus, a more proper API should look like: > > rte_vhost_feature_disable(device_type, feature_mask); > > Besides that, few public files and structures should be renamed, to > not let it bind to virtio-net. Specifically, they are: > > - virtio_net_device_ops --> vhost_device_ops > - rte_virtio_net.h --> rte_vhost.h > > Signed-off-by: Yuanhan Liu Acked-by: Thomas Monjalon