From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] app/test: fix sprintf with strlcat
Date: Tue, 02 Apr 2019 02:37:50 +0200
Message-ID: <11514522.tD9ysAbmMG@xps>
References: <1552475243-16215-1-git-send-email-pallantlax.poornima@intel.com>
 <f7t5zsmrify.fsf@dhcp-25.97.bos.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Aaron Conole <aconole@redhat.com>, reshma.pattan@intel.com,
 ferruh.yigit@intel.com, bruce.richardson@intel.com, stephen@networkplumber.org,
 stable@dpdk.org
To: Pallantla Poornima <pallantlax.poornima@intel.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <f7t5zsmrify.fsf@dhcp-25.97.bos.redhat.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

13/03/2019 14:51, Aaron Conole:
> Pallantla Poornima <pallantlax.poornima@intel.com> writes:
> 
> > sprintf function is not secure as it doesn't check the length of string.
> > More secure function strlcat is used.
> >
> > Fixes: 727909c592 ("app/test: introduce dynamic commands list")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>
> > ---
> > v2: Used strlcat to avoid buffer overflow.
> > ---
> 
> LGTM.
> 
> Reviewed-by: Aaron Conole <aconole@redhat.com>

Applied, thanks