From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [PATCH v4 1/8] net/ice: fix Tx function setting
Date: Fri, 22 Mar 2019 10:01:44 +0100
Message-ID: <1151d47d-4a77-f192-38f6-d7231fca30c8@redhat.com>
References: <1551340136-83843-1-git-send-email-wenzhuo.lu@intel.com>
 <1553149569-105555-1-git-send-email-wenzhuo.lu@intel.com>
 <1553149569-105555-2-git-send-email-wenzhuo.lu@intel.com>
 <eb8fd186-2f6e-ad4c-6faf-0d41729a2f58@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Cc: stable@dpdk.org
To: Wenzhuo Lu <wenzhuo.lu@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <eb8fd186-2f6e-ad4c-6faf-0d41729a2f58@redhat.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 3/22/19 9:46 AM, Maxime Coquelin wrote:
> 
> 
> On 3/21/19 7:26 AM, Wenzhuo Lu wrote:
>> The TX setting functions is not called.
> 
> s/functions/function/
> 
>>
>> Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
>> ---
>>   drivers/net/ice/ice_ethdev.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
>> index a23c63a..b804be1 100644
>> --- a/drivers/net/ice/ice_ethdev.c
>> +++ b/drivers/net/ice/ice_ethdev.c
>> @@ -1741,6 +1741,7 @@ static int ice_init_rss(struct ice_pf *pf)
>>       }
>>       ice_set_rx_function(dev);
>> +    ice_set_tx_function(dev);
>>       mask = ETH_VLAN_STRIP_MASK | ETH_VLAN_FILTER_MASK |
>>               ETH_VLAN_EXTEND_MASK;
>>
> 
> Other than that:
> 
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Sorry, just notice I didn't fetch my mailbox, so I didn't see the v5.
Anyway my comments seem to apply to v5 too.

Maxime