From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 0/3] Vhost app removes dependency of REFCNT Date: Fri, 24 Oct 2014 11:47:46 +0200 Message-ID: <11605757.Du0pTjUQ40@xps13> References: <1414138209-24431-1-git-send-email-changchun.ouyang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Ouyang Changchun Return-path: In-Reply-To: <1414138209-24431-1-git-send-email-changchun.ouyang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-10-24 16:10, Ouyang Changchun: > To remove the dependency of RTE_MBUF_REFCNT for vhost zero copy, > the mbuf need introduce EXTERNAL_MBUF(in ol_flags) to indicate it > attaches to an external buffer, say, from guest space. And don't > free the external buffer when freeing the mbuf itself in host, in > addition, RX function in PMD need make sure not overwrite this flag > when filling ol_flags from descriptors to mbuf. So you are replacing refcnt by something else which requires special handling in drivers. I feel this is not the right design. Why do you want to remove refcnt dependency? -- Thomas