From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] mk: replace the combined library with a linker script Date: Wed, 02 Mar 2016 13:40:59 +0100 Message-ID: <11773022.MfDspfNx6j@xps13> References: <079fa1cfc3550c8147ea8b137fa1bc0f34d051dc.1448375477.git.pmatilai@redhat.com> <56D5ABB4.3010609@redhat.com> <56D6DCE0.3010501@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Panu Matilainen Return-path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 9E8DA95C8 for ; Wed, 2 Mar 2016 13:42:34 +0100 (CET) Received: by mail-wm0-f54.google.com with SMTP id p65so76026901wmp.0 for ; Wed, 02 Mar 2016 04:42:34 -0800 (PST) In-Reply-To: <56D6DCE0.3010501@redhat.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-03-02 14:30, Panu Matilainen: > On 03/01/2016 04:48 PM, Panu Matilainen wrote: > > On 03/01/2016 03:40 PM, Thomas Monjalon wrote: > >> ping > >> I would like to be sure nothing is forgotten in this new revision. > > > > Sorry, didn't realize you were waiting for input from me, it feels a bit > > strange to comment on something supposedly coming from myself :) > > > >> 2016-02-23 23:20, Thomas Monjalon: > >>> From: Panu Matilainen > >>> > >>> The physically linked-together combined library has been an increasing > >>> source of problems, as was predicted when library and symbol versioning > >>> was introduced. Replace the complex and fragile construction with a > >>> simple linker script which achieves the same without all the problems, > >>> remove the related kludges from eg mlx drivers. > >>> > >>> Since creating the linker script is practically zero cost, remove the > >>> config option and just create it always. > >>> > >>> Based on a patch by Sergio Gonzales Monroy, linker script approach > >>> initially suggested by Neil Horman. > >>> > >>> Suggested-by: Sergio Gonzalez Monroy > >>> Suggested-by: Neil Horman > >>> Signed-off-by: Panu Matilainen > >>> Signed-off-by: Thomas Monjalon > >>> --- > >>> v2: > >>> - move RTE_LIBNAME assignment rte.vars.mk to rte.combinedlib.mk > >>> - update crypto > >>> - update doc > >>> - update rte.app.mk > >>> - update test-build.sh > >> > > > > Briefly tested, gets generated and installed as it should etc - looks > > good to me. > > Forgot to note that the patch doesn't apply anymore because of > scripts/test-build.sh changes, so it needs a rebase. Want me to send a > v3 or will you handle it when committing? > > On a related note, if this is about to go in then I'd rather have it > sooner than later because it also conflicts with the LDLIBS fixing > that's been slowly going on for months and months but been on hold > lately, partly because of this hangup. Applied, thanks