From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] igb_uio: revert open and release operations
Date: Fri, 13 Oct 2017 22:05:09 +0100
Message-ID: <11d7e3d2-a30c-cdc1-7609-c70aafde5aed@intel.com>
References: <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16F7E0E71@SHSMSX101.ccr.corp.intel.com>
 <20171013145104.17596-1-thomas@monjalon.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: luca.boccassi@att.com, gregory@weka.io, helin.zhang@intel.com,
 xuekun.hu@intel.com, harish.patil@cavium.com, dev@dpdk.org
To: Thomas Monjalon <thomas@monjalon.net>,
 shijith.thotton@caviumnetworks.com, qiming.yang@intel.com,
 jingjing.wu@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id A0E771B798
 for <dev@dpdk.org>; Fri, 13 Oct 2017 23:05:11 +0200 (CEST)
In-Reply-To: <20171013145104.17596-1-thomas@monjalon.net>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/13/2017 3:51 PM, Thomas Monjalon wrote:
> Some VF drivers cannot work with igb_uio because of the
> reset done in these functions.
> 
> First bug report:
> 	http://dpdk.org/ml/archives/dev/2017-September/075236.html
> 
> A partial reset was tried:
> 	http://dpdk.org/patch/28940
> 
> Second bug report after a partial revert trial:
> 	http://dpdk.org/ml/archives/dev/2017-September/076998.html
> 
> The patch author agreed to revert his patch:
> 	http://dpdk.org/ml/archives/dev/2017-October/077158.html
> 
> There are also some patches available to fix issues with i40e:
> 	http://dpdk.org/patch/30021
> 	http://dpdk.org/patch/30022
> 
> This patch takes the simple option of reverting the initial patch
> and gives more time to properly improve igb_uio and PMDs.
> 
> Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device file")
> 
> Reported-by: Qiming Yang <qiming.yang@intel.com>
> Reported-by: Jingjing Wu <jingjing.wu@intel.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Hi Thomas,

I put already some comment into other fix patch [1].

Mainly taking into account of current time for release, this patch make
sense, but I suggest giving a chance to the fix mentioned above.

Because the original patch is for safer igb_uio, and fixing a few times
reported issue.

Since this is rc1, we have time for testing, and many parties will be
doing tests. Lets get the fix for rc1, and if we find any issue revert
the patch?

Thanks,
ferruh

[1]
http://dpdk.org/ml/archives/dev/2017-October/079159.html