From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] crypto: normalize cryptodev pmd names with macros Date: Fri, 08 Jul 2016 12:03:12 +0200 Message-ID: <12140377.vURjlE434K@xps13> References: <1467905863-27038-1-git-send-email-nhorman@tuxdriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Bruce Richardson , "De Lara Guarch, Pablo" , Stephen Hemminger , Panu Matilainen To: Neil Horman Return-path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 9D6485934 for ; Fri, 8 Jul 2016 12:03:14 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id n127so9779159wme.1 for ; Fri, 08 Jul 2016 03:03:14 -0700 (PDT) In-Reply-To: <1467905863-27038-1-git-send-email-nhorman@tuxdriver.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-07-07 11:37, Neil Horman: > -PMD_REGISTER_DRIVER(cryptodev_aesni_mb_pmd_drvi, aesni_mb); > -DRIVER_REGISTER_PARAM_STRING(aesni_gcm, "max_nb_queue_pairs= " > +PMD_REGISTER_DRIVER(cryptodev_aesni_mb_pmd_drv, CRYPTODEV_NAME_AESNI_MB_PMD); > +DRIVER_REGISTER_PARAM_STRING(CRYPTODEV_NAME_AESNI_MB_PMD, "max_nb_queue_pairs= " > "max_nb_sessions= socket_id="); A coding style opinion: The line DRIVER_REGISTER_PARAM_STRING is a bit long and I think it would be nice to have only one param per line with an indent like this: DRIVER_REGISTER_PARAM_STRING(CRYPTODEV_NAME_AESNI_MB_PMD, "max_nb_queue_pairs= " "max_nb_sessions= " "socket_id=");