From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 1/3] stringfns: remove rte_snprintf Date: Wed, 25 Jun 2014 10:33:04 +0200 Message-ID: <12214985.ClK2CaJOyY@xps13> References: <20140624090253.140206a7@nehalam.linuxnetplumber.net> <59AF69C657FD0841A61C55336867B5B02CEE3359@IRSMSX103.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Richardson, Bruce" Return-path: In-Reply-To: <59AF69C657FD0841A61C55336867B5B02CEE3359-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-06-24 17:39, Richardson, Bruce: > From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Stephen Hemminger > > The function rte_snprintf serves no useful purpose. It is the > > same as snprintf() for all valid inputs. Just remove it and > > replace all uses in current code. > > NAK to this as is. > Approve of replacing all instance of the rte_snprintf function with the > standard version in all our code and libraries. However, rather than just > removing the function completely, I think we should just flag the function > as deprecated initially, and then later on look to remove it completely. I agree we should try to use the "deprecated" attribute when possible. So application porting effort will be smoother. But in this case, there is something different: as Stephen wrote, rte_snprintf is useless. It's useless inside the DPDK so it's even more useless for user applications. As it's really useless, it has no sense to keep it as deprecated. Please, let's simply remove it. -- Thomas