From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] eal: change init macro as exec environment specific Date: Wed, 03 Apr 2019 22:07:47 +0200 Message-ID: <12240942.ao6TnDaj5f@xps> References: <20170807120408.21975-1-jerin.jacob@caviumnetworks.com> <20190403192819.20243-1-jerinj@marvell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: "dev@dpdk.org" To: Jerin Jacob Kollanukkaran Return-path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 07B2E1B11A for ; Wed, 3 Apr 2019 22:07:51 +0200 (CEST) In-Reply-To: <20190403192819.20243-1-jerinj@marvell.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/04/2019 21:28, Jerin Jacob Kollanukkaran: > From: Jerin Jacob > > baremetal execution environments may have a different > method to enable RTE_INIT instead of using compiler > constructor and/or OS specific linker scheme. > Allow an option to override RTE_INIT* macros using > rte_os.h or appropriate header file. > > Signed-off-by: Jerin Jacob > --- > > v2: > - Leverage the rte_os.h created by Windows port to override RTE_INIT* macro if needed. > - Removed the exec environment specific librte_eal//eal/include/exec-env/rte_exec-env.h > file creation > - Removed the duplication of RTE_INIT_* definition on each rte_exec-env.h file > as it is common for Linux,FreeBSD and Windows port > > --- a/lib/librte_eal/common/include/rte_common.h > +++ b/lib/librte_eal/common/include/rte_common.h > @@ -106,8 +106,10 @@ typedef uint16_t unaligned_uint16_t; > * Priority number must be above 100. > * Lowest number is the first to run. > */ > +#ifndef RTE_INIT_PRIO /* Allow to override from eal */ > #define RTE_INIT_PRIO(func, prio) \ > static void __attribute__((constructor(RTE_PRIO(prio)), used)) func(void) > +#endif I did not think about such #ifndef, it's a lot simpler :) As a nit, I would just fix eal to uppercase EAL in the above comment. I may do it on apply. Acked-by: Thomas Monjalon