From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v4 0/4] Enable hotplug in vfio
Date: Mon, 15 Oct 2018 23:47:26 +0200
Message-ID: <12330354.ROdScU4qL8@xps>
References: <1534503091-31910-1-git-send-email-jia.guo@intel.com>
 <1538635483-92222-1-git-send-email-jia.guo@intel.com>
 <8e44ad47-133f-8e20-6600-df0df3ac8682@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Burakov, Anatoly" <anatoly.burakov@intel.com>,
 stephen@networkplumber.org, bruce.richardson@intel.com, ferruh.yigit@intel.com,
 konstantin.ananyev@intel.com, gaetan.rivet@6wind.com, jingjing.wu@intel.com,
 motih@mellanox.com, matan@mellanox.com, harry.van.haaren@intel.com,
 qi.z.zhang@intel.com, shaopeng.he@intel.com, bernard.iremonger@intel.com,
 arybchenko@solarflare.com, jblunck@infradead.org, shreyansh.jain@nxp.com,
 helin.zhang@intel.com, jerin.jacob@caviumnetworks.com
To: Jeff Guo <jia.guo@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 3EA1558FE
 for <dev@dpdk.org>; Mon, 15 Oct 2018 23:47:29 +0200 (CEST)
In-Reply-To: <8e44ad47-133f-8e20-6600-df0df3ac8682@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

04/10/2018 11:11, Burakov, Anatoly:
> On 04-Oct-18 7:44 AM, Jeff Guo wrote:
> > As we may know that the process of hotplug is different between igb_uio
> > and vfio. For igb_uio, it could use uevent notification and memory
> > failure handle mechanism for hot-unplug. But for vfio, when device is be
> > hot-unplugged, the uevent can not be detected immediately, because of the
> > vfio kernel module will use a special mechanism to guaranty the pci
> > device would not be deleted until the user space release the resources,
> > so it will use another req notifier event at first to notify user space
> > to release resources for hotplug.
> > 
> > This patch will add a new interrupt type of req notifier in eal interrupt,
> > and add the new interrupt handler in pci device to handle the req device
> > event. When the req notifier be detected, it can trigger the device event
> > callback process to process for hot-unplug. With this mechanism, hotplug
> > could be enable in vfio.
> 
> LGTM
> 
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

Applied, thanks