From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] app/testpmd: always build VF and MACsec
	functions
Date: Tue, 20 Jun 2017 09:31:56 +0200
Message-ID: <12382784.Ehh86DCXep@xps>
References: <20170615110221.1395-1-thomas@monjalon.net>
 <20170620065322.GA12786@debian-ZGViaWFuCg>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, jingjing.wu@intel.com, wenzhuo.lu@intel.com
To: Tiwei Bie <tiwei.bie@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 8B694374
 for <dev@dpdk.org>; Tue, 20 Jun 2017 09:31:57 +0200 (CEST)
In-Reply-To: <20170620065322.GA12786@debian-ZGViaWFuCg>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

20/06/2017 08:53, Tiwei Bie:
> On Thu, Jun 15, 2017 at 01:02:21PM +0200, Thomas Monjalon wrote:
> > These functions are supported only on ixgbe.
> [...]
> > @@ -3013,15 +3013,21 @@ set_vf_traffic(portid_t port_id, uint8_t is_rx, uint16_t vf, uint8_t on)
> >  
> >  	if (diag == 0)
> >  		return;
> > -	if(is_rx)
> > +	if(is_rx) {
> 
> It's better to also fix this coding style issue.

Yes you're right.
Will fix it when applying, thanks.