From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [[RFC PATCH]] lib/ether: fix 16-bit unaligned access Date: Tue, 08 Dec 2015 21:30:03 +0100 Message-ID: <12400151.dpjLSRpzoz@xps13> References: <1449602993-6047-1-git-send-email-viktorin@rehivetech.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Jan Viktorin Return-path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 0B6083784 for ; Tue, 8 Dec 2015 21:31:21 +0100 (CET) Received: by wmec201 with SMTP id c201so45280859wme.1 for ; Tue, 08 Dec 2015 12:31:19 -0800 (PST) In-Reply-To: <1449602993-6047-1-git-send-email-viktorin@rehivetech.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-12-08 20:29, Jan Viktorin: > (I considered to not add the cover-letter as this is just a single small patch. > I hope it does not matter a lot. Is there any convention how to do this?) The main interest of splitting patches or adding a cover letter it to have a place to explain the changes. When you have several changes, they deserve several patches to provide an accurate explanation. In such case, you may need a cover letter to describe the global idea of the series. A cover letter is also helpful for mail threading and acking all the series. When you have only one change, one email is enough. John, should we add this explanation in the contributing guide?