From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] Mem: Fixes small memory leak due to missing free. Date: Fri, 29 May 2015 19:42:35 +0200 Message-ID: <12488353.7GeDSJAbkN@xps13> References: <1432080295-8972-1-git-send-email-eziegenb@brocade.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Erik Ziegenbalg Return-path: Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 945BDB38D for ; Fri, 29 May 2015 20:41:17 +0200 (CEST) Received: by wgez8 with SMTP id z8so69862763wge.0 for ; Fri, 29 May 2015 11:41:17 -0700 (PDT) In-Reply-To: <1432080295-8972-1-git-send-email-eziegenb@brocade.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-05-19 17:04, Erik Ziegenbalg: > From: eziegenb > > A function in cmdline.c has a return that does not free buf properly. > > Signed-off-by: Erik Ziegenbalg You forgot to add a changelog and the previous acked-by: Acked-by: Stephen Hemminger Acked-by: John McNamara > - if (ret < 0) > + if (ret < 0){ checkpatch complains about a missing space. Applied with the above fix, thanks