public inbox for dev@dpdk.org
 help / color / mirror / Atom feed
* [PATCH v2 1/3] examples/l3fwd: extend NUMA nodes limit beyond 8
@ 2026-01-08  7:29 Liangxing Wang
  2026-01-19  9:19 ` Liangxing Wang
  0 siblings, 1 reply; 7+ messages in thread
From: Liangxing Wang @ 2026-01-08  7:29 UTC (permalink / raw)
  To: thomas, stephen, fengchengwen; +Cc: dev, Liangxing Wang, stable

For platforms with more than 8 NUMA nodes, examples l3fwd, l3fwd-graph,
and l3fwd-power fail when using cores on NUMA node 8 or above.

Use RTE_MAX_NUMA_NODES instead of 8 to extend NUMA nodes limit.

Cc: stable@dpdk.org

Signed-off-by: Liangxing Wang <wangliangxing@hygon.cn>
---
 examples/l3fwd-graph/main.c | 2 +-
 examples/l3fwd-power/main.c | 2 +-
 examples/l3fwd/l3fwd.h      | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/examples/l3fwd-graph/main.c b/examples/l3fwd-graph/main.c
index 92cdaa1ebe..d77b5f4ef6 100644
--- a/examples/l3fwd-graph/main.c
+++ b/examples/l3fwd-graph/main.c
@@ -56,7 +56,7 @@
 
 #define MAX_LCORE_PARAMS 1024
 
-#define NB_SOCKETS 8
+#define NB_SOCKETS RTE_MAX_NUMA_NODES
 
 /* Graph module */
 #define WORKER_MODEL_RTC "rtc"
diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index ec12d1cc0b..534e438d0b 100644
--- a/examples/l3fwd-power/main.c
+++ b/examples/l3fwd-power/main.c
@@ -115,7 +115,7 @@ RTE_LOG_REGISTER(l3fwd_power_logtype, l3fwd.power, INFO);
 
 #define BURST_TX_DRAIN_US 100 /* TX drain every ~100us */
 
-#define NB_SOCKETS 8
+#define NB_SOCKETS RTE_MAX_NUMA_NODES
 
 /* Configure how many packets ahead to prefetch, when reading packets */
 #define PREFETCH_OFFSET	3
diff --git a/examples/l3fwd/l3fwd.h b/examples/l3fwd/l3fwd.h
index 471e3b488f..ca9d0d2dd0 100644
--- a/examples/l3fwd/l3fwd.h
+++ b/examples/l3fwd/l3fwd.h
@@ -33,7 +33,7 @@
 #define VECTOR_SIZE_DEFAULT   MAX_PKT_BURST
 #define VECTOR_TMO_NS_DEFAULT 1E6 /* 1ms */
 
-#define NB_SOCKETS        8
+#define NB_SOCKETS        RTE_MAX_NUMA_NODES
 
 /* Configure how many packets ahead to prefetch, when reading packets */
 #define PREFETCH_OFFSET	  3
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* RE: [PATCH v2 1/3] examples/l3fwd: extend NUMA nodes limit beyond 8
  2026-01-08  7:29 [PATCH v2 1/3] examples/l3fwd: extend NUMA nodes limit beyond 8 Liangxing Wang
@ 2026-01-19  9:19 ` Liangxing Wang
  2026-01-21  9:40   ` Thomas Monjalon
  0 siblings, 1 reply; 7+ messages in thread
From: Liangxing Wang @ 2026-01-19  9:19 UTC (permalink / raw)
  To: thomas@monjalon.net, stephen@networkplumber.org,
	fengchengwen@huawei.com
  Cc: dev@dpdk.org

Hi,

Not sure for what reason, there wasn't any test check triggered by this patch. Do I have to submit a new patch version to trigger the tests? Thanks.

Regards,
Liangxing

> -----Original Message-----
> From: Liangxing Wang <wangliangxing@hygon.cn>
> Sent: 2026年1月8日 15:29
> To: thomas@monjalon.net; stephen@networkplumber.org;
> fengchengwen@huawei.com
> Cc: dev@dpdk.org; Liangxing Wang <wangliangxing@hygon.cn>;
> stable@dpdk.org
> Subject: [PATCH v2 1/3] examples/l3fwd: extend NUMA nodes limit beyond 8
> 
> For platforms with more than 8 NUMA nodes, examples l3fwd, l3fwd-graph,
> and l3fwd-power fail when using cores on NUMA node 8 or above.
> 
> Use RTE_MAX_NUMA_NODES instead of 8 to extend NUMA nodes limit.
> 
> Cc: stable@dpdk.org
> 
> Signed-off-by: Liangxing Wang <wangliangxing@hygon.cn>
> ---
>  examples/l3fwd-graph/main.c | 2 +-
>  examples/l3fwd-power/main.c | 2 +-
>  examples/l3fwd/l3fwd.h      | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/examples/l3fwd-graph/main.c b/examples/l3fwd-graph/main.c
> index 92cdaa1ebe..d77b5f4ef6 100644
> --- a/examples/l3fwd-graph/main.c
> +++ b/examples/l3fwd-graph/main.c
> @@ -56,7 +56,7 @@
> 
>  #define MAX_LCORE_PARAMS 1024
> 
> -#define NB_SOCKETS 8
> +#define NB_SOCKETS RTE_MAX_NUMA_NODES
> 
>  /* Graph module */
>  #define WORKER_MODEL_RTC "rtc"
> diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
> index ec12d1cc0b..534e438d0b 100644
> --- a/examples/l3fwd-power/main.c
> +++ b/examples/l3fwd-power/main.c
> @@ -115,7 +115,7 @@ RTE_LOG_REGISTER(l3fwd_power_logtype,
> l3fwd.power, INFO);
> 
>  #define BURST_TX_DRAIN_US 100 /* TX drain every ~100us */
> 
> -#define NB_SOCKETS 8
> +#define NB_SOCKETS RTE_MAX_NUMA_NODES
> 
>  /* Configure how many packets ahead to prefetch, when reading packets */
>  #define PREFETCH_OFFSET	3
> diff --git a/examples/l3fwd/l3fwd.h b/examples/l3fwd/l3fwd.h index
> 471e3b488f..ca9d0d2dd0 100644
> --- a/examples/l3fwd/l3fwd.h
> +++ b/examples/l3fwd/l3fwd.h
> @@ -33,7 +33,7 @@
>  #define VECTOR_SIZE_DEFAULT   MAX_PKT_BURST
>  #define VECTOR_TMO_NS_DEFAULT 1E6 /* 1ms */
> 
> -#define NB_SOCKETS        8
> +#define NB_SOCKETS        RTE_MAX_NUMA_NODES
> 
>  /* Configure how many packets ahead to prefetch, when reading packets */
>  #define PREFETCH_OFFSET	  3
> --
> 2.43.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 1/3] examples/l3fwd: extend NUMA nodes limit beyond 8
  2026-01-19  9:19 ` Liangxing Wang
@ 2026-01-21  9:40   ` Thomas Monjalon
  2026-01-21 10:50     ` Liangxing Wang
  2026-02-10 10:15     ` Liangxing Wang
  0 siblings, 2 replies; 7+ messages in thread
From: Thomas Monjalon @ 2026-01-21  9:40 UTC (permalink / raw)
  To: Liangxing Wang
  Cc: stephen@networkplumber.org, fengchengwen@huawei.com, dev@dpdk.org

19/01/2026 10:19, Liangxing Wang:
> Hi,
> 
> Not sure for what reason, there wasn't any test check triggered by this patch. Do I have to submit a new patch version to trigger the tests? Thanks.

The whole series got tested and reported on the last patch:
https://patches.dpdk.org/project/dpdk/patch/20260108073135.1279814-1-wangliangxing@hygon.cn/



^ permalink raw reply	[flat|nested] 7+ messages in thread

* RE: [PATCH v2 1/3] examples/l3fwd: extend NUMA nodes limit beyond 8
  2026-01-21  9:40   ` Thomas Monjalon
@ 2026-01-21 10:50     ` Liangxing Wang
  2026-02-10 10:15     ` Liangxing Wang
  1 sibling, 0 replies; 7+ messages in thread
From: Liangxing Wang @ 2026-01-21 10:50 UTC (permalink / raw)
  To: Thomas Monjalon
  Cc: stephen@networkplumber.org, fengchengwen@huawei.com, dev@dpdk.org

> 19/01/2026 10:19, Liangxing Wang:
> > Hi,
> >
> > Not sure for what reason, there wasn't any test check triggered by this patch.
> Do I have to submit a new patch version to trigger the tests? Thanks.
> 
> The whole series got tested and reported on the last patch:
> https://patches.dpdk.org/project/dpdk/patch/20260108073135.1279814-1-w
> angliangxing@hygon.cn/
> 
> 
Thanks for the info, Thomas. 

Liangxing

^ permalink raw reply	[flat|nested] 7+ messages in thread

* RE: [PATCH v2 1/3] examples/l3fwd: extend NUMA nodes limit beyond 8
  2026-01-21  9:40   ` Thomas Monjalon
  2026-01-21 10:50     ` Liangxing Wang
@ 2026-02-10 10:15     ` Liangxing Wang
  2026-02-10 13:30       ` Thomas Monjalon
  1 sibling, 1 reply; 7+ messages in thread
From: Liangxing Wang @ 2026-02-10 10:15 UTC (permalink / raw)
  To: Thomas Monjalon
  Cc: stephen@networkplumber.org, fengchengwen@huawei.com, dev@dpdk.org

Hi Thomas,

This simple series has been without a delegate for about a month. Could you help have a look? Thanks.

Regards,
Liangxing

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: 2026年1月21日 17:40
> To: Liangxing Wang <wangliangxing@hygon.cn>
> Cc: stephen@networkplumber.org; fengchengwen@huawei.com;
> dev@dpdk.org
> Subject: Re: [PATCH v2 1/3] examples/l3fwd: extend NUMA nodes limit
> beyond 8
> 
> 19/01/2026 10:19, Liangxing Wang:
> > Hi,
> >
> > Not sure for what reason, there wasn't any test check triggered by this patch.
> Do I have to submit a new patch version to trigger the tests? Thanks.
> 
> The whole series got tested and reported on the last patch:
> https://patches.dpdk.org/project/dpdk/patch/20260108073135.1279814-1-w
> angliangxing@hygon.cn/
> 
> 


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 1/3] examples/l3fwd: extend NUMA nodes limit beyond 8
  2026-02-10 10:15     ` Liangxing Wang
@ 2026-02-10 13:30       ` Thomas Monjalon
  2026-02-12 10:44         ` Liangxing Wang
  0 siblings, 1 reply; 7+ messages in thread
From: Thomas Monjalon @ 2026-02-10 13:30 UTC (permalink / raw)
  To: Liangxing Wang
  Cc: dev, stephen@networkplumber.org, fengchengwen@huawei.com,
	dev@dpdk.org

10/02/2026 11:15, Liangxing Wang:
> Hi Thomas,
> 
> This simple series has been without a delegate for about a month. Could you help have a look? Thanks.

There are more instances to fix in app/graph, examples/ip_reassembly and examples/vhost_crypto.
Could you fix all please?
I think you can split in 2 commits: examples and app.
In the case of apps, please check it is not increasing the memory usage too much.
Thanks



^ permalink raw reply	[flat|nested] 7+ messages in thread

* RE: [PATCH v2 1/3] examples/l3fwd: extend NUMA nodes limit beyond 8
  2026-02-10 13:30       ` Thomas Monjalon
@ 2026-02-12 10:44         ` Liangxing Wang
  0 siblings, 0 replies; 7+ messages in thread
From: Liangxing Wang @ 2026-02-12 10:44 UTC (permalink / raw)
  To: Thomas Monjalon
  Cc: dev@dpdk.org, stephen@networkplumber.org, fengchengwen@huawei.com,
	dev@dpdk.org

> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: 2026年2月10日 21:31
> 
> 10/02/2026 11:15, Liangxing Wang:
> > Hi Thomas,
> >
> > This simple series has been without a delegate for about a month. Could you
> help have a look? Thanks.
> 
> There are more instances to fix in app/graph, examples/ip_reassembly and
> examples/vhost_crypto.
> Could you fix all please?
> I think you can split in 2 commits: examples and app.
> In the case of apps, please check it is not increasing the memory usage too
> much.
> Thanks
> 
Okay, will do this. NB_SOCKETS in examples/ip_reassembly is not used. Will remove it.

Regards,
Liangxing


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-02-12 10:44 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-08  7:29 [PATCH v2 1/3] examples/l3fwd: extend NUMA nodes limit beyond 8 Liangxing Wang
2026-01-19  9:19 ` Liangxing Wang
2026-01-21  9:40   ` Thomas Monjalon
2026-01-21 10:50     ` Liangxing Wang
2026-02-10 10:15     ` Liangxing Wang
2026-02-10 13:30       ` Thomas Monjalon
2026-02-12 10:44         ` Liangxing Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox