From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re:
	=?utf-8?b?562U5aSNOiAgW1BBVENIXSBlYWwvcHBjNjQ6IGFkZCBz?=
	=?utf-8?q?upport_for_rte_pause?=
Date: Fri, 12 Oct 2018 08:50:06 +0200
Message-ID: <12734944.s5Hp39GJoV@xps>
References: <20181007061857.29451-1-jerin.jacob@caviumnetworks.com>
 <000001d461d2$adc87910$09596b30$@linux.vnet.ibm.com>
 <20181012041255.GA7250@jerin>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: Chao Zhu <chaozhu@linux.vnet.ibm.com>, dev@dpdk.org,
 gowrishankar.m@linux.vnet.ibm.com, ola.liljedahl@arm.com
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 7D2241B116
 for <dev@dpdk.org>; Fri, 12 Oct 2018 08:50:10 +0200 (CEST)
In-Reply-To: <20181012041255.GA7250@jerin>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

12/10/2018 06:12, Jerin Jacob:
> -----Original Message-----
> > Date: Fri, 12 Oct 2018 10:24:16 +0800
> > From: Chao Zhu <chaozhu@linux.vnet.ibm.com>
> > To: 'Jerin Jacob' <jerin.jacob@caviumnetworks.com>
> > CC: dev@dpdk.org, thomas@monjalon.net, gowrishankar.m@linux.vnet.ibm.co=
m,
> >  ola.liljedahl@arm.com
> > Subject: =E7=AD=94=E5=A4=8D: [dpdk-dev] [PATCH] eal/ppc64: add support =
for rte pause
> > X-Mailer: Microsoft Outlook 16.0
> >=20
> >=20
> > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6-----
> > =E5=8F=91=E4=BB=B6=E4=BA=BA: Jerin Jacob <jerin.jacob@caviumnetworks.co=
m>
> > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2018=E5=B9=B410=E6=9C=887=E6=97=
=A5 14:19
> > =E6=94=B6=E4=BB=B6=E4=BA=BA: Chao Zhu <chaozhu@linux.vnet.ibm.com>
> > =E6=8A=84=E9=80=81: dev@dpdk.org; thomas@monjalon.net; gowrishankar.m@l=
inux.vnet.ibm.com;
> > ola.liljedahl@arm.com; Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > =E4=B8=BB=E9=A2=98: [dpdk-dev] [PATCH] eal/ppc64: add support for rte p=
ause
> >=20
> > Add support for rte_pause() implementation for ppc64.
> >=20
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
> >=20
> > The reference implementation for Linux's cpu_relax() for ppc64 is at
> > https://elixir.bootlin.com/linux/latest/source/arch/powerpc/include/asm=
/proc
> > essor.h#L440
> >=20
> > ---
> >  lib/librte_eal/common/include/arch/ppc_64/rte_pause.h | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >=20
> > diff --git a/lib/librte_eal/common/include/arch/ppc_64/rte_pause.h
> > b/lib/librte_eal/common/include/arch/ppc_64/rte_pause.h
> > index 8bd835764..16e47ce22 100644
> > --- a/lib/librte_eal/common/include/arch/ppc_64/rte_pause.h
> > +++ b/lib/librte_eal/common/include/arch/ppc_64/rte_pause.h
> > @@ -9,10 +9,17 @@
> >  extern "C" {
> >  #endif
> >=20
> > +#include "rte_atomic.h"
> > +
> >  #include "generic/rte_pause.h"
> >=20
> >  static inline void rte_pause(void)
> >  {
> > +       /* Set hardware multi-threading low priority */
> > +       asm volatile("or 1,1,1");
> > +       /* Set hardware multi-threading medium priority */
> > +       asm volatile("or 2,2,2");
> > +       rte_compiler_barrier();
> >  }
> >=20
> >  #ifdef __cplusplus
> > --
> > 2.19.0
> >=20
> > Acked-by: Chao Zhu <chaozhu@linux.vnet.ibm.com>
>=20
> Thomas,
>=20
> Just noticed, due to some reason, The above Acked-by: is not reflected in=
 patchwork.
>=20
> http://patches.dpdk.org/patch/46195/
>=20
> Probably because, it was not a "inline" reply which patchwork couldn't pa=
rse it.

Or more probably, there are some special characters in the email or headers
which make patchwork parsing to fail.