From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v8 03/11] vdev: copy device info to eth_dev
	data
Date: Tue, 03 Nov 2015 18:17:32 +0100
Message-ID: <12812838.dX1On1osOA@xps13>
References: <1446555725-19540-4-git-send-email-bernard.iremonger@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Bernard Iremonger <bernard.iremonger@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com
 [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id 0559A8E88
 for <dev@dpdk.org>; Tue,  3 Nov 2015 18:18:45 +0100 (CET)
Received: by wicll6 with SMTP id ll6so74191280wic.0
 for <dev@dpdk.org>; Tue, 03 Nov 2015 09:18:44 -0800 (PST)
In-Reply-To: <1446555725-19540-4-git-send-email-bernard.iremonger@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Below, a lot of pci values are removed and break the build.
Will move in later patches.

2015-11-03 13:01, Bernard Iremonger:
> @@ -674,7 +674,11 @@ rte_pmd_init_internals(const char *name,
>  
>  	(*eth_dev)->data = data;
>  	(*eth_dev)->dev_ops = &ops;
> -	(*eth_dev)->pci_dev = pci_dev;
> +	(*eth_dev)->driver = NULL;
> +	(*eth_dev)->data->dev_flags = 0;
> +	(*eth_dev)->data->drv_name = drivername;
> +	(*eth_dev)->data->kdrv = RTE_KDRV_NONE;
> +	(*eth_dev)->data->numa_node = numa_node;

> @@ -571,10 +571,15 @@ eth_dev_null_create(const char *name,
>  
>  	eth_dev->data = data;
>  	eth_dev->dev_ops = &ops;
> -	eth_dev->pci_dev = pci_dev;
> -	eth_dev->driver = &rte_null_pmd;
> +
>  	TAILQ_INIT(&eth_dev->link_intr_cbs);

> @@ -874,8 +874,11 @@ rte_pmd_init_internals(const char *name, const unsigned nb_rx_queues,
>  
>  	(*eth_dev)->data = data;
>  	(*eth_dev)->dev_ops = &ops;
> -	(*eth_dev)->pci_dev = pci_dev;
> -	(*eth_dev)->driver = &rte_pcap_pmd;
> +	(*eth_dev)->data->dev_flags = RTE_ETH_DEV_DETACHABLE;
> +	(*eth_dev)->driver = NULL;
> +	(*eth_dev)->data->kdrv = RTE_KDRV_NONE;
> +	(*eth_dev)->data->drv_name = drivername;
> +	(*eth_dev)->data->numa_node = numa_node;
>  
>  	return 0;

> @@ -338,9 +337,13 @@ rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[],
>  	data->mac_addrs = &internals->address;
>  
>  	eth_dev->data = data;
> -	eth_dev->driver = &rte_ring_pmd;
> +	eth_dev->driver = NULL;
>  	eth_dev->dev_ops = &ops;
> -	eth_dev->pci_dev = pci_dev;
> +	eth_dev->data->dev_flags = RTE_ETH_DEV_DETACHABLE;
> +	eth_dev->data->kdrv = RTE_KDRV_NONE;
> +	eth_dev->data->drv_name = drivername;
> +	eth_dev->data->numa_node = numa_node;
> +
>  	TAILQ_INIT(&(eth_dev->link_intr_cbs));
>  

> @@ -688,8 +688,12 @@ eth_dev_xenvirt_create(const char *name, const char *params,
>  
>  	eth_dev->data = data;
>  	eth_dev->dev_ops = &ops;
> +
>  	eth_dev->data->dev_flags = RTE_PCI_DRV_DETACHABLE;
> -	eth_dev->pci_dev = pci_dev;
> +	eth_dev->data->kdrv = RTE_KDRV_NONE;
> +	eth_dev->data->drv_name = drivername;
> +	eth_dev->driver = NULL;
> +	eth_dev->data->numa_node = numa_node;
>  
>  	eth_dev->rx_pkt_burst = eth_xenvirt_rx;
>  	eth_dev->tx_pkt_burst = eth_xenvirt_tx;
>