From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] igb_uio: remove device reset in open Date: Fri, 03 Nov 2017 20:24:22 +0100 Message-ID: <12814007.65nxXEtm0z@xps> References: <506f596c-f7e3-56b1-d13a-17b49bc3945a@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Ferruh Yigit , Stephen Hemminger , "Tan, Jianfeng" , Jingjing Wu , "Thotton, Shijith" , Gregory Etelson , "Patil, Harish" , dev@dpdk.org, George Prekas , Sergio Gonzalez Monroy To: "Mody, Rasesh" Return-path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 00E5D1B6B7 for ; Fri, 3 Nov 2017 20:24:24 +0100 (CET) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/11/2017 20:18, Mody, Rasesh: > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] > > On 11/2/2017 11:45 AM, Mody, Rasesh wrote: > > > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] > > >> On 11/2/2017 10:34 AM, Mody, Rasesh wrote: > > > We are ok as we have at least some way to disable the reset, please send a > > patch. > > > > Sent http://dpdk.org/dev/patchwork/patch/31143/, can you please test? > > The testing of BNX2X looks OK with this patch. However, the solution has following drawbacks: > - an application will need to be recompiled to have the igb_uio kernel module rebuilt to support bnx2x devices > - this will break pre-compiled solutions that are provided with an OS such as RHOSP or as part of a pre-compiled VNF > > We can live with this temporary solution for now. In the long term, we may have to revisit this. > We are also looking at why bnx2x FLR is taking this long. Yes, I think the long term solution should be to fix your PMD or your firmware. Please keep us posted when you find the root cause with your device. Thanks