From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] librte_pmd_af_packet: add compile-time checks for kernel-specific options Date: Fri, 05 Dec 2014 17:37:53 +0100 Message-ID: <128892442.7P4I1l0Tzy@xps13> References: <1417729325-9410-1-git-send-email-linville@tuxdriver.com> <8974312.4KPnm9h9PX@xps13> <20141205162453.GB28319@tuxdriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "John W. Linville" Return-path: In-Reply-To: <20141205162453.GB28319-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-12-05 11:24, John W. Linville: > On Fri, Dec 05, 2014 at 10:30:53AM +0100, Thomas Monjalon wrote: > > Hi John, > > > > 2014-12-04 16:42, John W. Linville: > > > This allows the PMD to compile with kernels that don't support the > > > options in question. The "#if defined(...)" lines are a bit ugly, > > > but I don't know of any better way to accomplish the task. > > > > > > Signed-off-by: John W. Linville > > > --- > > > lib/librte_pmd_af_packet/rte_eth_af_packet.c | 16 ++++++++++++---- > > > 1 file changed, 12 insertions(+), 4 deletions(-) > > > > Is it possible to enable compilation of this PMD in default configuration? > > I guess it shouldn't fail anymore with this patch? > > Yes, I believe so. I checked the kernel git history for when each > definition was included. Everything else was older than the 2.6.32 > kernel. > > I think you can reenable this PMD in the common_linuxapp config file > if you like. I'll send a patch if you prefer for me to do so. OK, I'm going do it. Thanks -- Thomas