From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] net/bonding: allow configuring jumbo frames
 without slaves
Date: Fri, 14 Apr 2017 10:40:26 +0100
Message-ID: <12d3d9ac-ed90-745d-a553-86a8fe5d19f1@intel.com>
References: <CGME20170407150720eucas1p2ea1d3b1c4f1e4dd394f98ff4d8573c32@eucas1p2.samsung.com>
 <1491577632-31289-1-git-send-email-i.maximets@samsung.com>
 <20170410022225.GA5162@roosta>
 <32c66606-95aa-3187-a4f6-89563d290793@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Heetae Ahn <heetae82.ahn@samsung.com>,
 Bernard Iremonger <bernard.iremonger@intel.com>, stable@dpdk.org
To: Declan Doherty <declan.doherty@intel.com>,
 Eric Kinzie <ehkinzie@gmail.com>, Ilya Maximets <i.maximets@samsung.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <32c66606-95aa-3187-a4f6-89563d290793@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/14/2017 9:31 AM, Declan Doherty wrote:
> On 10/04/17 03:22, Eric Kinzie wrote:
>> On Fri Apr 07 18:07:12 +0300 2017, Ilya Maximets wrote:
>>> Currently, 'rte_eth_dev_configure' fails on attempt to setup
>>> max_rx_pkt_len > 2048 if no slaves was added to bonded device.
>>>
>>> For example:
>>>
>>> 	rte_eth_dev_attach("eth_bond0,slave=05:00.0,mode=l34", &id)
>>> 	conf.rxmode.jumbo_frame = 1;
>>> 	conf.rxmode.max_rx_pkt_len = 9000;
>>> 	rte_eth_dev_configure(id, 1, 1, &conf)
>>>
>>> Result:
>>> 	EAL: Initializing pmd_bond for eth_bond0
>>> 	EAL: Create bonded device eth_bond0 on port 4 in mode 2 on socket 0.
>>> 	rte_eth_dev_configure: ethdev port_id=4 \
>>> 		max_rx_pkt_len 9018 > max valid value 2048
>>>
>>> It's expected that slaves will be added to bonded device inside
>>> 'rte_eth_dev_configure' and proper 'max_rx_pktlen' configured
>>> for all of them.
>>>
>>> Failure happens because of hardcoded low value of 'max_rx_pktlen'.
>>> Increasing of this value to ETHER_MAX_JUMBO_FRAME_LEN will allow
>>> above scenario (attach + configure).
>>>
>>> It is important because it is the way OVS wants to work with
>>> all DPDK devices (including virtual).
>>> Changing the default hardcoded value makes no harm because
>>> all the slaves' related code uses only 'candidate_max_rx_pktlen'
>>> variable.
>>>

>>> Fixes: 6cfc6a4f0d61 ("net/bonding: inherit maximum Rx packet length")
>>> CC: stable@dpdk.org

>>> Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
>>> ---
> ...
>>
>> Reviewed-by: Eric Kinzie <ehkinzie@gmail.com>
>>
> 
> Acked-by: Declan Doherty <declan.doherty@gmail.com>

Applied to dpdk-next-net/master, thanks.