From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v11 0/5] link bonding library Date: Mon, 30 Jun 2014 11:21:02 +0200 Message-ID: <13010138.0NjEKNQfRt@xps13> References: <1403864324-12022-1-git-send-email-declan.doherty@intel.com> <1404064161-26370-1-git-send-email-declan.doherty@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Declan Doherty Return-path: In-Reply-To: <1404064161-26370-1-git-send-email-declan.doherty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Declan, 2014-06-29 18:49, Declan Doherty: > This patchset contains the name change fix in the link bonding library > makefile. I have also put a change into the unit test application makefile > so that the link bonding tests are not built if the library is also not > being built. It doesn't make sense to split the bonding libraries APIs into > a seperate library, as they are directly coupled to with the bonding > library implmentation You fixed optional building but there is still an issue when building shared library. As you don't want to split the library to separate the PMD plugin from the specific API, I suggest to not consider it as a plugin (unlike other PMDs). I've sent some patches about these 2 topics. If you agree, I'll apply them, merged with your serie. Thanks -- Thomas