From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 1/8] drivers/common/dpaa2: Run time assembler for Descriptor formation Date: Wed, 07 Dec 2016 09:33:17 +0100 Message-ID: <13107823.ZnI407z9cY@xps13> References: <20161205125540.6419-1-akhil.goyal@nxp.com> <5589636.gHNnFhEcxp@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, declan.doherty@intel.com, pablo.de.lara.guarch@intel.com, Hemant Agrawal , Horia =?utf-8?B?R2VhbnTEgw==?= To: Akhil Goyal Return-path: Received: from mail-wj0-f169.google.com (mail-wj0-f169.google.com [209.85.210.169]) by dpdk.org (Postfix) with ESMTP id 096012B96 for ; Wed, 7 Dec 2016 09:33:20 +0100 (CET) Received: by mail-wj0-f169.google.com with SMTP id xy5so352998191wjc.0 for ; Wed, 07 Dec 2016 00:33:20 -0800 (PST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-12-07 06:24, Akhil Goyal: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > 2016-12-05 18:25, Akhil Goyal: > > FLib is a library which helps in making the descriptors which is > > understood by NXP's SEC hardware. > > This patch provides header files for command words which can be used > > for descritptor formation. > > It seems this code is old. Does it exist as a standalone library somewhere? > Where was it hosted before duplicating it in DPDK? > > Why do you want to have a common directory drivers/common/dpaa2/flib instead of a sub-directory in the crypto driver? > > [Akhil] This is not really a library. This is a set of header files which is required for compilation. We have 2 other cypto drivers (for different platforms viz: Non-DPAA and DPAA1_QORIQ) which uses the same flib. So we put it in common directory. We plan to send patches for other drivers in the upcoming releases. Please Akhil, could you answer to the three questions?