From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] vhost: remove lockless enqueue to the virtio ring Date: Tue, 15 Mar 2016 00:13:06 +0100 Message-ID: <13376800.Cqouxc5gkz@xps13> References: <1451918787-85887-1-git-send-email-huawei.xie@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "ann.zhuangyanying@huawei.com" To: "Xie, Huawei" , yuanhan.liu@linux.intel.com Return-path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id B3D622C62 for ; Tue, 15 Mar 2016 00:14:30 +0100 (CET) Received: by mail-wm0-f54.google.com with SMTP id l68so122084201wml.0 for ; Mon, 14 Mar 2016 16:14:30 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-01-05 07:16, Xie, Huawei: > On 1/5/2016 2:42 PM, Xie, Huawei wrote: > > This patch removes the internal lockless enqueue implmentation. > > DPDK doesn't support receiving/transmitting packets from/to the same > > queue. Vhost PMD wraps vhost device as normal DPDK port. DPDK > > applications normally have their own lock implmentation when enqueue > > packets to the same queue of a port. > > > > The atomic cmpset is a costly operation. This patch should help > > performance a bit. > > > > Signed-off-by: Huawei Xie > This patch modifies the API's behavior, which is also a trivial ABI > change. In my opinion, application shouldn't rely on previous behavior. > Anyway, i am checking how to declare the ABI change. I guess this patch is now obsolete?