From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH 1/4] net/failsafe: replace local device with
	shared data
Date: Thu, 28 Feb 2019 17:27:13 +0100
Message-ID: <13394612.Q6ZXlXj6hl@xps>
References: <1551368952-1871-1-git-send-email-rasland@mellanox.com>
 <1551368952-1871-2-git-send-email-rasland@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: "gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>,
 "dev@dpdk.org" <dev@dpdk.org>
To: Raslan Darawsheh <rasland@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 00E5B4C8D
 for <dev@dpdk.org>; Thu, 28 Feb 2019 17:27:25 +0100 (CET)
In-Reply-To: <1551368952-1871-2-git-send-email-rasland@mellanox.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

28/02/2019 16:49, Raslan Darawsheh:
> In multiprocess context, the private structure is shared between
> processes. The back reference from private to generic data was using
> a pointer to a per process eth_dev. It's now changed to a reference of
> the shared data.
> 
> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> -	struct sub_device *subs;
> +	struct sub_device *subs; /* shared between processes */

I think this comment would have more sense if added in patch 3
which is about subdev.
Sorry for nitpicking ;)