From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] librte_pmd_packet: add PMD for
	AF_PACKET-based virtual devices
Date: Sat, 12 Jul 2014 00:30:34 +0200
Message-ID: <13642580.3DAGicjMse@xps13>
References: <1405024369-30058-1-git-send-email-linville@tuxdriver.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: "John W. Linville" <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1405024369-30058-1-git-send-email-linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

About the form of the patch, I have 2 comments:

1) A doc explaining the design, the dependencies and how it can be used would 
be a great help. Could you write it in rst format?

2) checkpatch.pl returns these errors:

ERROR:SPACING: space required before the open parenthesis '('
#468: FILE: lib/librte_pmd_packet/rte_eth_packet.c:250:
+               if(sockfd != -1)

ERROR:SPACING: space required before the open parenthesis '('
#471: FILE: lib/librte_pmd_packet/rte_eth_packet.c:253:
+               if(sockfd != -1)

ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#712: FILE: lib/librte_pmd_packet/rte_eth_packet.c:494:
+               ifr.ifr_name[ifnamelen]='\0';

Thanks
-- 
Thomas