From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 1/5] ethdev: add vmdq rx mode Date: Thu, 06 Nov 2014 14:55:31 +0100 Message-ID: <13741309.jhnrGuo18k@xps13> References: <1414381533-30370-1-git-send-email-changchun.ouyang@intel.com> <1414732757-7241-1-git-send-email-changchun.ouyang@intel.com> <1414732757-7241-2-git-send-email-changchun.ouyang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Ouyang Changchun Return-path: In-Reply-To: <1414732757-7241-2-git-send-email-changchun.ouyang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-10-31 13:19, Ouyang Changchun: > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -577,6 +577,7 @@ struct rte_eth_vmdq_rx_conf { > uint8_t default_pool; /**< The default pool, if applicable */ > uint8_t enable_loop_back; /**< Enable VT loop back */ > uint8_t nb_pool_maps; /**< We can have up to 64 filters/mappings */ > + uint32_t rx_mode; /**< RX mode for vmdq */ You are adding the field rx_mode in struct rte_eth_vmdq_rx_conf. So the comment "RX mode for vmdq" is not really informative :) It would be more interesting to explain which kind of value this field must contain. Something like "flags from ETH_VMDQ_ACCEPT_*". -- Thomas