From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: Clarification for - SoC specific driver based common sub component placing Date: Fri, 18 Nov 2016 14:43:20 +0100 Message-ID: <13846356.5jcoesaunv@xps13> References: <7765421.y4BZ5iUgMg@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Hemant Agrawal Return-path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 505202C10 for ; Fri, 18 Nov 2016 14:43:23 +0100 (CET) Received: by mail-wm0-f52.google.com with SMTP id a197so39212846wmd.0 for ; Fri, 18 Nov 2016 05:43:23 -0800 (PST) In-Reply-To: <7765421.y4BZ5iUgMg@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-11-18 14:38, Thomas Monjalon: > 2016-11-18 12:44, Hemant Agrawal: > > We like to introduce NXP's DPAA (Data Path Acceleration Architecture Gen2) Poll mode drivers into the DPDK. > > > > We need some clarification w.r.t the right placing of some dependent components, which can be common across drivers. E.g. We have hardware queue and buffer manager driver. This will be used by both network driver and crypto driver. But it is specific to NXP platform only. > > > > What is the right place for such common hardware specific components in DPDK? > > 1. Add a new generic Soc library structure. e.g. librte_soc/nxp/. For each soc configuration only the required components will be compiled-in. > > 2. Create a drivers/soc/nxp/dpaa2 structure to keep common driver libs. And link the network and crypto drivers to it. > > 3. Add it to main network driver and make the crypto driver dependent on it. > > Your question is more generic than SoC context. > You just want to share some code between drivers, right? > What about building a library located in drivers/common/nxp/ ? I'm a bit reluctant to have company name in file hierarchy, as it not something stable. And especially for NXP/Qualcomm... In this case would it be better to name the directory drivers/common/dpaa2/ ?