From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 01/10] ethdev: add a generic flow and new behavior switch to fdir Date: Wed, 24 Feb 2016 16:02:42 +0100 Message-ID: <13893420.AuWBYNZ43L@xps13> References: <20160224144313.GF19616@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Kumar Sanghvi , Nirranjan Kirubaharan To: Rahul Lakkireddy Return-path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 33559298F for ; Wed, 24 Feb 2016 16:04:17 +0100 (CET) Received: by mail-wm0-f54.google.com with SMTP id a4so33875935wme.1 for ; Wed, 24 Feb 2016 07:04:17 -0800 (PST) In-Reply-To: <20160224144313.GF19616@bricha3-MOBL3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-02-24 14:43, Bruce Richardson: > On Wed, Feb 03, 2016 at 02:02:22PM +0530, Rahul Lakkireddy wrote: > > Add a new raw packet flow that allows specifying generic flow input. > > > > Add the ability to provide masks for fields in flow to allow range of > > values. > > > > Add a new behavior switch. > > > > Add the ability to provide behavior arguments to allow rewriting matched > > fields with new values. Ex: allows to provide new ip and port addresses > > to rewrite the fields of packets matching a filter rule before NAT'ing. > > > Thomas, any comments as ethdev maintainer? Yes, some comments. First, there are several different changes in the same patch. It must be split. Then I don't understand at all the raw flow filter. What is a raw flow? How behavior_arg must be used?