From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v4] librte_pipeline: add support for packet redirection at action handlers Date: Mon, 07 Mar 2016 12:01:51 +0100 Message-ID: <13895624.4YkCxv7Jex@xps13> References: <1456951307-35264-1-git-send-email-jasvinder.singh@intel.com> <1457002906-69859-1-git-send-email-jasvinder.singh@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Jasvinder Singh Return-path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id B31162C62 for ; Mon, 7 Mar 2016 12:03:28 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id l68so80292834wml.0 for ; Mon, 07 Mar 2016 03:03:28 -0800 (PST) In-Reply-To: <1457002906-69859-1-git-send-email-jasvinder.singh@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Jasvinder, Don't hesitate to leave some blank lines in your message, it's free :) 2016-03-03 11:01, Jasvinder Singh: > Currently, there is no mechanism that allows the pipeline ports (in/out) and > table action handlers to override the default forwarding decision (as > previously configured per input port or in the table entry). Therefore, new > pipeline API functions have been added which allows action handlers to > hijack packets and remove them from the pipeline processing, and then either > drop them or send them out of the pipeline on any output port. The port > (in/out) and table action handler prototypes have been changed for making > use of these new API functions. This feature will be helpful to implement > functions such as exception handling (e.g. TTL =0), load balancing etc. > Changes are made to the ports and table action handlers defined in > app/test_pipeline and ip_pipeline sample application. I have the feeling it would be easier to parse if the structure changes were done in a separate commit, then introduce the new function. You have forgotten to remove the deprecation notice.