From: Daniel Kan <dan-nm7580oGLDTQT0dZR+AlfA@public.gmane.org>
To: dev-VfR2kkLFssw@public.gmane.org
Subject: [PATCH v3] app/testpmd: fix RSS rx by setting mq_mode
Date: Wed, 15 Jan 2014 16:31:39 -0800 [thread overview]
Message-ID: <1389832299-30033-1-git-send-email-dan@nyansa.com> (raw)
In-Reply-To: <CAEykdvr+9JD0MKwwGqf-4+jSnVaPFGPnMYnr_VFfgCn2+hPcEg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
The mq_mode was not set when rxq is > 0; it's defaulted to ETH_MQ_RX_NONE.
As a result, RSS remains inactive. The fix is to set mq_mode to ETH_MQ_RX_RSS
when hf is non-zero.
This bug was introduced by commit 243db2ddee3094a2cb39fdd4b17e26df4e7735e1
igb/ixgbe: ETH_MQ_RX_NONE should disable RSS
Signed-off-by: Daniel Kan <dan-nm7580oGLDTQT0dZR+AlfA@public.gmane.org>
---
Enable RSS even if rxq=1 based on comment from Maxime Leroy.
app/test-pmd/testpmd.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index b11eb2e..42e1fdb 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -1546,6 +1546,9 @@ init_port_config(void)
if (nb_rxq > 0) {
port->dev_conf.rx_adv_conf.rss_conf.rss_key = NULL;
port->dev_conf.rx_adv_conf.rss_conf.rss_hf = rss_hf;
+ if (rss_hf != 0) {
+ port->dev_conf.rxmode.mq_mode = ETH_MQ_RX_RSS;
+ }
} else {
port->dev_conf.rx_adv_conf.rss_conf.rss_key = NULL;
port->dev_conf.rx_adv_conf.rss_conf.rss_hf = 0;
--
1.7.9.5
next prev parent reply other threads:[~2014-01-16 0:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-11 2:46 [PATCH] app/testpmd: fix RSS rx by setting mq_mode Daniel Kan
[not found] ` <1389408367-19376-1-git-send-email-dan-nm7580oGLDTQT0dZR+AlfA@public.gmane.org>
2014-01-13 10:31 ` Thomas Monjalon
[not found] ` <201401131131.06203.thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-01-13 11:18 ` Ananyev, Konstantin
[not found] ` <2601191342CEEE43887BDE71AB97725808E4ED39-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-01-13 11:32 ` Thomas Monjalon
2014-01-13 19:17 ` [PATCH v2] app/testpmd: fix RSS " Daniel Kan
[not found] ` <1389640630-21003-1-git-send-email-dan-nm7580oGLDTQT0dZR+AlfA@public.gmane.org>
2014-01-14 17:42 ` Maxime Leroy
[not found] ` <CAEykdvr+9JD0MKwwGqf-4+jSnVaPFGPnMYnr_VFfgCn2+hPcEg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-01-14 19:57 ` Daniel Kan
[not found] ` <8FCA4423-9762-47DD-868C-028FD8AAE2BB-nm7580oGLDTQT0dZR+AlfA@public.gmane.org>
2014-01-14 21:34 ` Thomas Monjalon
2014-01-16 0:27 ` [PATCH v3] Daniel Kan
2014-01-16 0:31 ` Daniel Kan [this message]
[not found] ` <1389832299-30033-1-git-send-email-dan-nm7580oGLDTQT0dZR+AlfA@public.gmane.org>
2014-01-16 12:34 ` [PATCH v3] app/testpmd: fix RSS rx by setting mq_mode Maxime Leroy
[not found] ` <CAEykdvp9RP9rA8t_stNNygAw9rZyLRxUo3G-ej-Wy=pEkvTzrg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-01-17 11:25 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389832299-30033-1-git-send-email-dan@nyansa.com \
--to=dan-nm7580ogldtqt0dzr+alfa@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).