* [memnic PATCH] pmd: fix attributes
@ 2014-01-24 15:59 Olivier Matz
[not found] ` <1390579140-23841-1-git-send-email-olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Olivier Matz @ 2014-01-24 15:59 UTC (permalink / raw)
To: dev-VfR2kkLFssw
Add missing "const" and remove useless "rte_unused" attributes.
Signed-off-by: Olivier Matz <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
---
pmd/pmd_memnic.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/pmd/pmd_memnic.c b/pmd/pmd_memnic.c
index d16eb0d..bc01746 100644
--- a/pmd/pmd_memnic.c
+++ b/pmd/pmd_memnic.c
@@ -57,7 +57,7 @@ struct memnic_adapter {
struct ether_addr mac_addr;
};
-static inline struct memnic_adapter *get_adapter(struct rte_eth_dev *dev)
+static inline struct memnic_adapter *get_adapter(const struct rte_eth_dev *dev)
{
return (struct memnic_adapter *)(dev->data->dev_private);
}
@@ -67,7 +67,7 @@ struct memnic_queue {
uint8_t port_id;
};
-static struct memnic_queue *memnic_queue_alloc(struct rte_eth_dev *dev,
+static struct memnic_queue *memnic_queue_alloc(const struct rte_eth_dev *dev,
int tx, uint16_t id)
{
struct memnic_adapter *adapter = get_adapter(dev);
@@ -119,7 +119,7 @@ static void memnic_dev_stop(struct rte_eth_dev *dev)
return;
}
-static void memnic_dev_infos_get(__rte_unused struct rte_eth_dev *dev,
+static void memnic_dev_infos_get(struct rte_eth_dev *dev,
struct rte_eth_dev_info *dev_info)
{
dev_info->driver_name = dev->driver->pci_drv.name;
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <1390579140-23841-1-git-send-email-olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>]
* Re: [memnic PATCH] pmd: fix attributes [not found] ` <1390579140-23841-1-git-send-email-olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> @ 2014-01-30 11:37 ` Hiroshi Shimamoto [not found] ` <7F861DC0615E0C47A872E6F3C5FCDDBD0102D0D4-ZmjkEB1lVlLt6d3pZDjeaEtBU8KWyXPq@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Hiroshi Shimamoto @ 2014-01-30 11:37 UTC (permalink / raw) To: Olivier Matz, dev-VfR2kkLFssw@public.gmane.org > Subject: [dpdk-dev] [memnic PATCH] pmd: fix attributes > > Add missing "const" and remove useless "rte_unused" attributes. Good catch. Looks fine to me. thanks, Hiroshi > > Signed-off-by: Olivier Matz <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> > --- > pmd/pmd_memnic.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/pmd/pmd_memnic.c b/pmd/pmd_memnic.c > index d16eb0d..bc01746 100644 > --- a/pmd/pmd_memnic.c > +++ b/pmd/pmd_memnic.c > @@ -57,7 +57,7 @@ struct memnic_adapter { > struct ether_addr mac_addr; > }; > > -static inline struct memnic_adapter *get_adapter(struct rte_eth_dev *dev) > +static inline struct memnic_adapter *get_adapter(const struct rte_eth_dev *dev) > { > return (struct memnic_adapter *)(dev->data->dev_private); > } > @@ -67,7 +67,7 @@ struct memnic_queue { > uint8_t port_id; > }; > > -static struct memnic_queue *memnic_queue_alloc(struct rte_eth_dev *dev, > +static struct memnic_queue *memnic_queue_alloc(const struct rte_eth_dev *dev, > int tx, uint16_t id) > { > struct memnic_adapter *adapter = get_adapter(dev); > @@ -119,7 +119,7 @@ static void memnic_dev_stop(struct rte_eth_dev *dev) > return; > } > > -static void memnic_dev_infos_get(__rte_unused struct rte_eth_dev *dev, > +static void memnic_dev_infos_get(struct rte_eth_dev *dev, > struct rte_eth_dev_info *dev_info) > { > dev_info->driver_name = dev->driver->pci_drv.name; > -- > 1.8.4.rc3 ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <7F861DC0615E0C47A872E6F3C5FCDDBD0102D0D4-ZmjkEB1lVlLt6d3pZDjeaEtBU8KWyXPq@public.gmane.org>]
* Re: [memnic PATCH] pmd: fix attributes [not found] ` <7F861DC0615E0C47A872E6F3C5FCDDBD0102D0D4-ZmjkEB1lVlLt6d3pZDjeaEtBU8KWyXPq@public.gmane.org> @ 2014-02-04 13:05 ` Thomas Monjalon 0 siblings, 0 replies; 3+ messages in thread From: Thomas Monjalon @ 2014-02-04 13:05 UTC (permalink / raw) To: Olivier Matz; +Cc: dev-VfR2kkLFssw 30/01/2014 12:37, Hiroshi Shimamoto: > > Add missing "const" and remove useless "rte_unused" attributes. > > Good catch. Looks fine to me. > > > Signed-off-by: Olivier Matz <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> Applied, thanks. -- Thomas ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-04 13:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-24 15:59 [memnic PATCH] pmd: fix attributes Olivier Matz
[not found] ` <1390579140-23841-1-git-send-email-olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-01-30 11:37 ` Hiroshi Shimamoto
[not found] ` <7F861DC0615E0C47A872E6F3C5FCDDBD0102D0D4-ZmjkEB1lVlLt6d3pZDjeaEtBU8KWyXPq@public.gmane.org>
2014-02-04 13:05 ` Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).