dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
From: Olivier Matz <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: dev-VfR2kkLFssw@public.gmane.org
Subject: [PATCH 10/11] kvargs: make the NULL key to match all entries
Date: Tue, 28 Jan 2014 17:06:43 +0100	[thread overview]
Message-ID: <1390925204-10800-11-git-send-email-olivier.matz@6wind.com> (raw)
In-Reply-To: <1390925204-10800-1-git-send-email-olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>

In rte_kvargs_process() and rte_kvargs_count(), if the key_match
argument is NULL, process all entries.

Signed-off-by: Olivier Matz <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
---
 lib/librte_kvargs/rte_kvargs.c | 4 ++--
 lib/librte_kvargs/rte_kvargs.h | 5 +++--
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/lib/librte_kvargs/rte_kvargs.c b/lib/librte_kvargs/rte_kvargs.c
index 1ff7056..3d65437 100644
--- a/lib/librte_kvargs/rte_kvargs.c
+++ b/lib/librte_kvargs/rte_kvargs.c
@@ -139,7 +139,7 @@ rte_kvargs_count(const struct rte_kvargs *kvlist, const char *key_match)
 	ret = 0;
 	for (i = 0; i < kvlist->count; i++) {
 		pair = &kvlist->pairs[i];
-		if (strcmp(pair->key, key_match) == 0)
+		if (key_match == NULL || strcmp(pair->key, key_match) == 0)
 			ret++;
 	}
 
@@ -160,7 +160,7 @@ rte_kvargs_process(const struct rte_kvargs *kvlist,
 
 	for (i = 0; i < kvlist->count; i++) {
 		pair = &kvlist->pairs[i];
-		if (strcmp(pair->key, key_match) == 0) {
+		if (key_match == NULL || strcmp(pair->key, key_match) == 0) {
 			if ((*handler)(pair->key, pair->value, opaque_arg) < 0)
 				return -1;
 		}
diff --git a/lib/librte_kvargs/rte_kvargs.h b/lib/librte_kvargs/rte_kvargs.h
index c080c06..e375547 100644
--- a/lib/librte_kvargs/rte_kvargs.h
+++ b/lib/librte_kvargs/rte_kvargs.h
@@ -120,7 +120,8 @@ void rte_kvargs_free(struct rte_kvargs *kvlist);
  * @param kvlist
  *   The rte_kvargs structure
  * @param key_match
- *   The key on which the handler should be called
+ *   The key on which the handler should be called, or NULL to process handler
+ *   on all associations
  * @param handler
  *   The function to call for each matching key
  * @param opaque_arg
@@ -139,7 +140,7 @@ int rte_kvargs_process(const struct rte_kvargs *kvlist,
  * @param kvlist
  *   The rte_kvargs structure
  * @param key_match
- *   The key that should match
+ *   The key that should match, or NULL to count all associations
 
  * @return
  *   The number of entries
-- 
1.8.4.rc3

  parent reply	other threads:[~2014-01-28 16:06 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-28 16:06 [PATCH 00/11] add rte_kvargs library: a key/value args parser Olivier Matz
     [not found] ` <1390925204-10800-1-git-send-email-olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-01-28 16:06   ` [PATCH 01/11] kvargs: add a new library to parse key/value arguments Olivier Matz
     [not found]     ` <1390925204-10800-2-git-send-email-olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-01-29 15:45       ` Richardson, Bruce
2014-01-28 16:06   ` [PATCH 02/11] kvargs: use the new library in pmd_pcap Olivier Matz
     [not found]     ` <1390925204-10800-3-git-send-email-olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-01-29 15:46       ` Richardson, Bruce
2014-01-28 16:06   ` [PATCH 03/11] kvargs: remove driver name in arguments Olivier Matz
     [not found]     ` <1390925204-10800-4-git-send-email-olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-01-29 15:47       ` Richardson, Bruce
2014-01-28 16:06   ` [PATCH 04/11] kvargs: remove useless size field Olivier Matz
     [not found]     ` <1390925204-10800-5-git-send-email-olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-01-29 17:14       ` Richardson, Bruce
2014-01-28 16:06   ` [PATCH 05/11] kvargs: rework API to fix memory leak Olivier Matz
     [not found]     ` <1390925204-10800-6-git-send-email-olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-01-30 11:22       ` Richardson, Bruce
2014-01-28 16:06   ` [PATCH 06/11] kvargs: simpler parsing and allow duplicated keys Olivier Matz
     [not found]     ` <1390925204-10800-7-git-send-email-olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-01-29 17:17       ` Richardson, Bruce
     [not found]         ` <59AF69C657FD0841A61C55336867B5B01A995C12-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-01-29 22:17           ` Olivier MATZ
2014-01-30 11:23       ` Richardson, Bruce
2014-01-28 16:06   ` [PATCH 07/11] kvargs: be strict when matching a key Olivier Matz
     [not found]     ` <1390925204-10800-8-git-send-email-olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-01-30 11:23       ` Richardson, Bruce
2014-01-28 16:06   ` [PATCH 08/11] kvargs: add const attribute in handler parameters Olivier Matz
     [not found]     ` <1390925204-10800-9-git-send-email-olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-01-30 11:24       ` Richardson, Bruce
2014-01-28 16:06   ` [PATCH 09/11] kvargs: add the key in handler pameters Olivier Matz
     [not found]     ` <1390925204-10800-10-git-send-email-olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-01-30 11:34       ` Richardson, Bruce
2014-01-28 16:06   ` Olivier Matz [this message]
     [not found]     ` <1390925204-10800-11-git-send-email-olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-01-30 11:34       ` [PATCH 10/11] kvargs: make the NULL key to match all entries Richardson, Bruce
2014-01-28 16:06   ` [PATCH 11/11] kvargs: add test case in app/test Olivier Matz
     [not found]     ` <1390925204-10800-12-git-send-email-olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-01-30 11:35       ` Richardson, Bruce
2014-02-04 14:53   ` [PATCH 00/11] add rte_kvargs library: a key/value args parser Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1390925204-10800-11-git-send-email-olivier.matz@6wind.com \
    --to=olivier.matz-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).