dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
From: David Marchand <david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: anatoly.burakov-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: [PATCH 0/3] remove RTE_EAL_UNBIND_PORTS related code
Date: Mon, 14 Apr 2014 14:51:49 +0200	[thread overview]
Message-ID: <1397479912-4906-1-git-send-email-david.marchand@6wind.com> (raw)
In-Reply-To: <C6ECDF3AB251BE4894318F4E451236975927466C-kPTMFJFq+rGvNW/NfzhIbrfspsVTdybXVpNB7YpNyf8@public.gmane.org>

Hello Anatoly, 

I think we might want to start a discussion on what should be done by the eal
and what should be done by the drivers themselves. But this can be done later.

For now, I have a problem with your patch as it breaks drivers that use
RTE_PCI_DRV_FORCE_UNBIND flag, since it removes the part where this flag is
handled. Besides, I can see some remaining parts mentioning pci_switch_module()
in comments.

So, here is a patchset that should do the trick.
It does some cleanup before removing the RTE_EAL_UNBIND_PORTS part.


Regards, 
-- 
David Marchand

David Marchand (3):
  pci: pci_switch_module cleanup
  pci: move RTE_PCI_DRV_FORCE_UNBIND handling out of #ifdef
  pci: remove deprecated RTE_EAL_UNBIND_PORTS option

 lib/librte_eal/linuxapp/eal/eal_pci.c |  183 +--------------------------------
 1 file changed, 2 insertions(+), 181 deletions(-)

-- 
1.7.10.4

  parent reply	other threads:[~2014-04-14 12:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-11 11:53 [PATCH] Remove RTE_EAL_UNBIND_PORTS-related code Burakov, Anatoly
     [not found] ` <C6ECDF3AB251BE4894318F4E451236975927466C-kPTMFJFq+rGvNW/NfzhIbrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-04-14 12:51   ` David Marchand [this message]
     [not found]     ` <1397479912-4906-1-git-send-email-david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-04-14 12:51       ` [PATCH 1/3] pci: pci_switch_module cleanup David Marchand
     [not found]         ` <1397479912-4906-2-git-send-email-david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-04-15  8:39           ` Burakov, Anatoly
2014-04-14 12:51       ` [PATCH 2/3] pci: move RTE_PCI_DRV_FORCE_UNBIND handling out of #ifdef David Marchand
     [not found]         ` <1397479912-4906-3-git-send-email-david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-04-15  8:40           ` Burakov, Anatoly
2014-04-14 12:51       ` [PATCH 3/3] pci: remove deprecated RTE_EAL_UNBIND_PORTS option David Marchand
     [not found]         ` <1397479912-4906-4-git-send-email-david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-04-15  8:41           ` Burakov, Anatoly
2014-04-28 13:18           ` David Marchand
2014-04-14 13:12       ` [PATCH 0/3] remove RTE_EAL_UNBIND_PORTS related code Burakov, Anatoly
     [not found]         ` <C6ECDF3AB251BE4894318F4E451236975927EE1E-kPTMFJFq+rF9qrmMLTLiibfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-04-14 14:19           ` David Marchand
     [not found]             ` <534BEE72.4070205-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-04-14 14:39               ` Burakov, Anatoly
     [not found]                 ` <C6ECDF3AB251BE4894318F4E451236975927EEB6-kPTMFJFq+rF9qrmMLTLiibfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-04-15  8:15                   ` Thomas Monjalon
2014-04-15  8:33                     ` Burakov, Anatoly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1397479912-4906-1-git-send-email-david.marchand@6wind.com \
    --to=david.marchand-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=anatoly.burakov-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).