From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Horman Subject: [PATCH] eal: check error conditinos for every loop iteration Date: Wed, 16 Apr 2014 06:50:40 -0400 Message-ID: <1397645440-14813-1-git-send-email-nhorman@tuxdriver.com> To: dev-VfR2kkLFssw@public.gmane.org Return-path: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" The return code for rte_cpu_get_flag_enabled is only checked on the termination of the for loop that it is called inside, but should be checked for every iteration it makes through the for loop. This is caused by some silly missing brackets. Simply add them in Signed-off-by: Neil Horman Reported-by: Pablo De Lara Guarch CC: Pablo De Lara Guarch CC: Thomas Monjalon --- lib/librte_eal/common/eal_common_cpuflags.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_cpuflags.c b/lib/librte_eal/common/eal_common_cpuflags.c index f9c1840..5c0927c 100644 --- a/lib/librte_eal/common/eal_common_cpuflags.c +++ b/lib/librte_eal/common/eal_common_cpuflags.c @@ -255,7 +255,7 @@ rte_cpu_check_supported(void) unsigned i; int ret; - for (i = 0; i < sizeof(compile_time_flags)/sizeof(compile_time_flags[0]); i++) + for (i = 0; i < sizeof(compile_time_flags)/sizeof(compile_time_flags[0]); i++) { ret = rte_cpu_get_flag_enabled(compile_time_flags[i]); if (ret < 0) { @@ -271,4 +271,5 @@ rte_cpu_check_supported(void) cpu_feature_table[compile_time_flags[i]].name); exit(1); } + } } -- 1.8.3.1