From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Hunt, David" <david.hunt@intel.com>
Subject: Re: [PATCH v2 3/4] power: clean up of kvm files
Date: Mon, 11 Dec 2017 10:45:58 +0000
Message-ID: <13b4f489-99d6-aafe-e078-a26c8e2bc440@intel.com>
References: <20171128132203.43181-1-marko.kovacevic@intel.com>
 <20171128132203.43181-3-marko.kovacevic@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
To: Marko Kovacevic <marko.kovacevic@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id ABCC9271
 for <dev@dpdk.org>; Mon, 11 Dec 2017 11:46:01 +0100 (CET)
In-Reply-To: <20171128132203.43181-3-marko.kovacevic@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Marko,


On 28/11/2017 1:22 PM, Marko Kovacevic wrote:
> Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
> ---
>   lib/librte_power/Makefile                          |  2 +-
>   .../{rte_power_kvm_vm.c => power_kvm_vm.c}         | 28 +++++++++++-----------
>   .../{rte_power_kvm_vm.h => power_kvm_vm.h}         | 28 +++++++++++-----------
>   lib/librte_power/rte_power.c                       | 28 +++++++++++-----------
>   4 files changed, 43 insertions(+), 43 deletions(-)
>   rename lib/librte_power/{rte_power_kvm_vm.c => power_kvm_vm.c} (83%)
>   rename lib/librte_power/{rte_power_kvm_vm.h => power_kvm_vm.h} (85%)
>
> diff --git a/lib/librte_power/Makefile b/lib/librte_power/Makefile
> index bf5a55e..a35c50a 100644
> --- a/lib/librte_power/Makefile
> +++ b/lib/librte_power/Makefile
> @@ -43,7 +43,7 @@ LIBABIVER := 1
>   
>   # all source are stored in SRCS-y
>   SRCS-$(CONFIG_RTE_LIBRTE_POWER) := rte_power.c power_acpi_cpufreq.c
> -SRCS-$(CONFIG_RTE_LIBRTE_POWER) += rte_power_kvm_vm.c guest_channel.c
> +SRCS-$(CONFIG_RTE_LIBRTE_POWER) += power_kvm_vm.c guest_channel.c
>   
>   # install this header file
>   SYMLINK-$(CONFIG_RTE_LIBRTE_POWER)-include := rte_power.h
> diff --git a/lib/librte_power/rte_power_kvm_vm.c b/lib/librte_power/power_kvm_vm.c
> similarity index 83%
> rename from lib/librte_power/rte_power_kvm_vm.c
> rename to lib/librte_power/power_kvm_vm.c
>

--snip--

Could I suggest you add the following into the commit message?

"rename private header file rte_power_kvm_vm.c to power_kvm_vm.c. This 
prevents the private functions from leaking into the documentation.
Change any private functions from rte_<function_name> to just 
<function_name>. Reserve the rte_ for public functions. "

Regards,
Dave.