From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konstantin Ananyev Subject: [PATCH] fix for eth_pcap_tx() can cause mbuf corruption Date: Wed, 28 May 2014 15:47:02 +0100 Message-ID: <1401288422-10449-1-git-send-email-konstantin.ananyev@intel.com> Return-path: To: dev-VfR2kkLFssw@public.gmane.org To: dev-VfR2kkLFssw@public.gmane.org List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" If pcap_sendpacket() fails, then eth_pcap_tx shouldn't silently free that mbuf and continue. Signed-off-by: Konstantin Ananyev --- lib/librte_pmd_pcap/rte_eth_pcap.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/librte_pmd_pcap/rte_eth_pcap.c b/lib/librte_pmd_pcap/rte_eth_pcap.c index dc4670c..6f026ab 100644 --- a/lib/librte_pmd_pcap/rte_eth_pcap.c +++ b/lib/librte_pmd_pcap/rte_eth_pcap.c @@ -239,8 +239,9 @@ eth_pcap_tx(void *queue, mbuf = bufs[i]; ret = pcap_sendpacket(tx_queue->pcap, (u_char*) mbuf->pkt.data, mbuf->pkt.data_len); - if(likely(!ret)) - num_tx++; + if (unlikely(ret != 0)) + break; + num_tx++; rte_pktmbuf_free(mbuf); } -- 1.7.7.6