From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] lib: change rte_ring dequeue to guarantee ordering before tail update Date: Thu, 21 Jul 2016 23:26:50 +0200 Message-ID: <14017551.U6D1dIIx0P@xps13> References: <20160715043951.32040-1-juhamatti.kuusisaari@coriant.com> <2601191342CEEE43887BDE71AB97725836B7E32F@irsmsx105.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Ananyev, Konstantin" To: Juhamatti Kuusisaari Return-path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 0FC5C568D for ; Thu, 21 Jul 2016 23:26:52 +0200 (CEST) Received: by mail-wm0-f48.google.com with SMTP id f65so35518299wmi.0 for ; Thu, 21 Jul 2016 14:26:52 -0700 (PDT) In-Reply-To: <2601191342CEEE43887BDE71AB97725836B7E32F@irsmsx105.ger.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > Consumer queue dequeuing must be guaranteed to be done fully before the tail is updated. This is not guaranteed with a read barrier, > > changed to a write barrier just before tail update which in practice guarantees correct order of reads and writes. > > > > Signed-off-by: Juhamatti Kuusisaari > > Acked-by: Konstantin Ananyev Applied, thanks