From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konstantin Ananyev Subject: [PATCHv2 1/4] e1000: do not release queue on alloc error Date: Mon, 9 Jun 2014 18:26:14 +0100 Message-ID: <1402334777-27379-2-git-send-email-konstantin.ananyev@intel.com> References: <1402334777-27379-1-git-send-email-konstantin.ananyev@intel.com> Return-path: To: dev-VfR2kkLFssw@public.gmane.org In-Reply-To: <1402334777-27379-1-git-send-email-konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> To: dev-VfR2kkLFssw@public.gmane.org List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" If igb_alloc_rx_queue_mbufs() would fail to allocate an mbuf for RX queue, it calls igb_rx_queue_release(rxq). That causes rxq to be silently freed, without updating dev->data->rx_queues[]. So any further reference to it will trigger the SIGSEGV. Same thing in em PMD too. To fix: igb_alloc_rx_queue_mbufs() should just return an error to the caller and let upper layer to deal with the probem. That's what ixgbe PMD is doing right now. Signed-off-by: Konstantin Ananyev --- lib/librte_pmd_e1000/em_rxtx.c | 1 - lib/librte_pmd_e1000/igb_rxtx.c | 1 - 2 files changed, 2 deletions(-) diff --git a/lib/librte_pmd_e1000/em_rxtx.c b/lib/librte_pmd_e1000/em_rxtx.c index 4f98a3f..5ed4def 100644 --- a/lib/librte_pmd_e1000/em_rxtx.c +++ b/lib/librte_pmd_e1000/em_rxtx.c @@ -1580,7 +1580,6 @@ em_alloc_rx_queue_mbufs(struct em_rx_queue *rxq) if (mbuf == NULL) { PMD_INIT_LOG(ERR, "RX mbuf alloc failed " "queue_id=%hu\n", rxq->queue_id); - em_rx_queue_release(rxq); return (-ENOMEM); } diff --git a/lib/librte_pmd_e1000/igb_rxtx.c b/lib/librte_pmd_e1000/igb_rxtx.c index ae53428..e35649f 100644 --- a/lib/librte_pmd_e1000/igb_rxtx.c +++ b/lib/librte_pmd_e1000/igb_rxtx.c @@ -1818,7 +1818,6 @@ igb_alloc_rx_queue_mbufs(struct igb_rx_queue *rxq) if (mbuf == NULL) { PMD_INIT_LOG(ERR, "RX mbuf alloc failed " "queue_id=%hu\n", rxq->queue_id); - igb_rx_queue_release(rxq); return (-ENOMEM); } dma_addr = -- 1.8.3.1