From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo de Lara Subject: [PATCH] pcap: Fixed bug in eth_pcap_rx function Date: Tue, 5 Aug 2014 11:18:20 +0100 Message-ID: <1407233900-9734-1-git-send-email-pablo.de.lara.guarch@intel.com> To: dev-VfR2kkLFssw@public.gmane.org Return-path: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Normally, bufs[i] stores the mbuf pointer, the index of buf[i] is the loop count i, but if header.len > buf_size, DPDK will free the mbuf, but the loop count i still increases, so some of the items in bufs[] might be NULL ponter, causing a potential DPDK core. Using num_rx as the index for bufs[] solves the problem. Signed-off-by: Pablo de Lara --- lib/librte_pmd_pcap/rte_eth_pcap.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/librte_pmd_pcap/rte_eth_pcap.c b/lib/librte_pmd_pcap/rte_eth_pcap.c index c77ee25..eebe768 100644 --- a/lib/librte_pmd_pcap/rte_eth_pcap.c +++ b/lib/librte_pmd_pcap/rte_eth_pcap.c @@ -154,7 +154,7 @@ eth_pcap_rx(void *queue, rte_memcpy(mbuf->pkt.data, packet, header.len); mbuf->pkt.data_len = (uint16_t)header.len; mbuf->pkt.pkt_len = mbuf->pkt.data_len; - bufs[i] = mbuf; + bufs[num_rx] = mbuf; num_rx++; } else { /* pcap packet will not fit in the mbuf, so drop packet */ -- 1.7.0.7