dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
From: <zhang.zhangkun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: <dev-VfR2kkLFssw@public.gmane.org>
Cc: zhangkun <zhangk.zhangkun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Subject: [PATCH] there are some memory leak about Dir operator
Date: Tue, 19 Aug 2014 11:39:40 +0800	[thread overview]
Message-ID: <1408419580-19684-1-git-send-email-zhang.zhangkun@huawei.com> (raw)

From: zhangkun <zhangk.zhangkun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>


Signed-off-by: zhangkun <zhangk.zhangkun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
---
 lib/librte_eal/linuxapp/eal/eal_hugepage_info.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c b/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
index b72a205..d784b7c 100644
--- a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
+++ b/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
@@ -311,12 +311,14 @@ eal_hugepage_info_init(void)
 				/* if blocking lock failed */
 				if (flock(hpi->lock_descriptor, LOCK_EX) == -1) {
 					RTE_LOG(CRIT, EAL, "Failed to lock hugepage directory!\n");
+					closedir(dir);
 					return -1;
 				}
 				/* clear out the hugepages dir from unused pages */
-				if (clear_hugedir(hpi->hugedir) == -1)
+				if (clear_hugedir(hpi->hugedir) == -1) {
+					closedir(dir);
 					return -1;
-
+				}
 				/* for now, put all pages into socket 0,
 				 * later they will be sorted */
 				hpi->num_pages[0] = get_num_hugepages(dirent->d_name);
-- 
1.7.3.1.msysgit.0

             reply	other threads:[~2014-08-19  3:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-19  3:39 zhang.zhangkun-hv44wF8Li93QT0dZR+AlfA [this message]
     [not found] ` <1408419580-19684-1-git-send-email-zhang.zhangkun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-08-19  3:53   ` [PATCH] there are some memory leak about Dir operator Zhang, Helin
     [not found]     ` <F35DEAC7BCE34641BA9FAC6BCA4A12E70A77F3DE-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-08-19  6:10       ` 答复: " Zhangkun (K)
  -- strict thread matches above, loose matches on Subject: below --
2014-08-19  3:51 zhang.zhangkun-hv44wF8Li93QT0dZR+AlfA
     [not found] ` <1408420271-11568-1-git-send-email-zhang.zhangkun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-08-29 10:43   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1408419580-19684-1-git-send-email-zhang.zhangkun@huawei.com \
    --to=zhang.zhangkun-hv44wf8li93qt0dzr+alfa@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=zhangk.zhangkun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).