* [PATCH] testpmd: fix crash in txonly mode and when using tx_first
@ 2014-09-01 10:31 David Marchand
[not found] ` <1409567471-18978-1-git-send-email-david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: David Marchand @ 2014-09-01 10:31 UTC (permalink / raw)
To: dev-VfR2kkLFssw
From: Adrien Mazarguil <adrien.mazarguil-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
This crash was believed fixed by commit 5886ae07d211e4b5e49806dd183812beb31c67ad,
but the actual issue is that the core ID provided to rte_lcore_to_socket_id() is
wrong. It must be looked up in fwd_lcores_cpuids[].
Signed-off-by: Adrien Mazarguil <adrien.mazarguil-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Signed-off-by: David Marchand <david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
---
app/test-pmd/testpmd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index a112559..8f5f9ad 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -614,7 +614,9 @@ init_config(void)
* Records which Mbuf pool to use by each logical core, if needed.
*/
for (lc_id = 0; lc_id < nb_lcores; lc_id++) {
- mbp = mbuf_pool_find(rte_lcore_to_socket_id(lc_id));
+ mbp = mbuf_pool_find(
+ rte_lcore_to_socket_id(fwd_lcores_cpuids[lc_id]));
+
if (mbp == NULL)
mbp = mbuf_pool_find(0);
fwd_lcores[lc_id]->mbp = mbp;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] testpmd: fix crash in txonly mode and when using tx_first
[not found] ` <1409567471-18978-1-git-send-email-david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
@ 2014-09-01 10:59 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2014-09-01 10:59 UTC (permalink / raw)
To: David Marchand; +Cc: dev-VfR2kkLFssw
2014-09-01 12:31, David Marchand:
> From: Adrien Mazarguil <adrien.mazarguil-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
>
> This crash was believed fixed by commit 5886ae07d211e4b5e49806dd183812beb31c67ad,
> but the actual issue is that the core ID provided to rte_lcore_to_socket_id() is
> wrong. It must be looked up in fwd_lcores_cpuids[].
>
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> Signed-off-by: David Marchand <david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Applied for version 1.7.1.
Thanks
--
Thomas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-01 10:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-01 10:31 [PATCH] testpmd: fix crash in txonly mode and when using tx_first David Marchand
[not found] ` <1409567471-18978-1-git-send-email-david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-09-01 10:59 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).