dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: dev-VfR2kkLFssw@public.gmane.org
Subject: [PATCH v2 04/13] mbuf: introduce a flag to indicate a control mbuf
Date: Thu, 11 Sep 2014 14:15:38 +0100	[thread overview]
Message-ID: <1410441347-22840-5-git-send-email-bruce.richardson@intel.com> (raw)
In-Reply-To: <1410441347-22840-1-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Since the flags field is now 64-bits, we can allow one bit to be used to
indicate a control i.e. non-packet mbuf. Dedicate the high bit (bit 63)
for this purpose and add in a utility macro to test if a given mbuf has
the bit set or not.

Updated in V2:
* Fix typo in comment in rte_mbuf.h

Signed-off-by: Bruce Richardson <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
 lib/librte_mbuf/rte_mbuf.c |  2 ++
 lib/librte_mbuf/rte_mbuf.h | 19 +++++++++++++++++++
 2 files changed, 21 insertions(+)

diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c
index 9dfcac3..52e7574 100644
--- a/lib/librte_mbuf/rte_mbuf.c
+++ b/lib/librte_mbuf/rte_mbuf.c
@@ -69,7 +69,9 @@ rte_ctrlmbuf_init(struct rte_mempool *mp,
 		void *_m,
 		__attribute__((unused)) unsigned i)
 {
+	struct rte_mbuf *m = _m;
 	rte_pktmbuf_init(mp, opaque_arg, _m, i);
+	m->ol_flags |= CTRL_MBUF_FLAG;
 }
 
 /*
diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
index 0e20e31..b9a1c66 100644
--- a/lib/librte_mbuf/rte_mbuf.h
+++ b/lib/librte_mbuf/rte_mbuf.h
@@ -91,6 +91,7 @@ extern "C" {
 #define PKT_TX_IPV4_CSUM     0x1000 /**< Alias of PKT_TX_IP_CKSUM. */
 #define PKT_TX_IPV4          PKT_RX_IPV4_HDR /**< IPv4 with no IP checksum offload. */
 #define PKT_TX_IPV6          PKT_RX_IPV6_HDR /**< IPv6 packet */
+
 /*
  * Bit 14~13 used for L4 packet type with checksum enabled.
  *     00: Reserved
@@ -106,6 +107,9 @@ extern "C" {
 /* Bit 15 */
 #define PKT_TX_IEEE1588_TMST 0x8000 /**< TX IEEE1588 packet to timestamp. */
 
+/* Use final bit of flags to indicate a control mbuf */
+#define CTRL_MBUF_FLAG       (1ULL << 63)
+
 /**
  * Bit Mask to indicate what bits required for building TX context
  */
@@ -471,6 +475,21 @@ void rte_ctrlmbuf_init(struct rte_mempool *mp, void *opaque_arg,
  */
 #define rte_ctrlmbuf_len(m) rte_pktmbuf_data_len(m)
 
+/**
+ * Tests if an mbuf is a control mbuf
+ *
+ * @param m
+ *   The mbuf to be tested
+ * @return
+ *   - True (1) if the mbuf is a control mbuf
+ *   - False(0) otherwise
+ */
+static inline int
+rte_is_ctrlmbuf(struct rte_mbuf *m)
+{
+	return (!!(m->ol_flags & CTRL_MBUF_FLAG));
+}
+
 /* Operations on pkt mbuf */
 
 /**
-- 
1.9.3

  parent reply	other threads:[~2014-09-11 13:15 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-03 15:49 [PATCH 00/13] Mbuf Structure Rework, part 2 Bruce Richardson
     [not found] ` <1409759378-10113-1-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-03 15:49   ` [PATCH 01/13] mbuf: replace data pointer by an offset Bruce Richardson
     [not found]     ` <1409759378-10113-2-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-08  9:52       ` Olivier MATZ
     [not found]         ` <540D7C5F.8000406-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-09-08  9:55           ` Olivier MATZ
2014-09-03 15:49   ` [PATCH 02/13] mbuf: reorder fields by time of use Bruce Richardson
     [not found]     ` <1409759378-10113-3-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-08 10:17       ` Olivier MATZ
2014-09-03 15:49   ` [PATCH 03/13] mbuf: add packet_type field Bruce Richardson
     [not found]     ` <1409759378-10113-4-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-08 10:17       ` Olivier MATZ
     [not found]         ` <540D8228.809-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-09-08 10:33           ` Yerden Zhumabekov
     [not found]             ` <540D85E0.4030203-8EHiFRVJVgQ@public.gmane.org>
2014-09-08 11:17               ` Olivier MATZ
     [not found]                 ` <CAD16F236028A64DBBC0158B1636EA4510F3E4F8@SHSMSX104.ccr.corp.intel.com>
     [not found]                   ` <CAD16F236028A64DBBC0158B1636EA4510F3E4F8-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-09-09  3:57                     ` Liu, Jijiang
     [not found]                 ` <540D903E.1060206-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-09-09  3:59                   ` Zhang, Helin
     [not found]                     ` <F35DEAC7BCE34641BA9FAC6BCA4A12E70A784E49-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-09-09  8:02                       ` Olivier MATZ
     [not found]                         ` <540EB428.9060706-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-09-09  8:45                           ` Zhang, Helin
2014-09-09  9:47                           ` Richardson, Bruce
2014-09-09 15:05                   ` Jim Thompson
2014-09-03 15:49   ` [PATCH 04/13] mbuf: expand ol_flags field to 64-bits Bruce Richardson
     [not found]     ` <1409759378-10113-5-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-08 10:25       ` Olivier MATZ
     [not found]         ` <540D8421.7070808-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-09-09  9:00           ` Richardson, Bruce
2014-09-03 15:49   ` [PATCH 05/13] mbuf: introduce a flag to indicate a control mbuf Bruce Richardson
     [not found]     ` <1409759378-10113-6-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-08 11:53       ` Olivier MATZ
2014-09-03 15:49   ` [PATCH 06/13] mbuf: minor changes for readability Bruce Richardson
     [not found]     ` <1409759378-10113-7-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-08 12:03       ` Olivier MATZ
2014-09-03 15:49   ` [PATCH 07/13] mbuf: use macros only to access the mbuf metadata Bruce Richardson
     [not found]     ` <1409759378-10113-8-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-08 12:05       ` Olivier MATZ
     [not found]         ` <540D9B95.3020504-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-09-09  9:01           ` Richardson, Bruce
     [not found]             ` <59AF69C657FD0841A61C55336867B5B0343EFAA3-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-09-12 16:56               ` Dumitrescu, Cristian
     [not found]                 ` <3EB4FA525960D640B5BDFFD6A3D891262E070D42-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-09-12 21:02                   ` Olivier MATZ
     [not found]                     ` <54135F63.2090401-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-09-16 20:07                       ` Dumitrescu, Cristian
     [not found]                         ` <3EB4FA525960D640B5BDFFD6A3D891262E071FE6-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-09-16 22:06                           ` Ramia, Kannan Babu
     [not found]                             ` <682698A055A0F44AA47192B20141149711B1FFE6-yHIBzpp8AekFyVwBAnZdSLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-09-17 10:31                               ` Richardson, Bruce
     [not found]                                 ` <59AF69C657FD0841A61C55336867B5B0343F2BD2-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-09-17 14:01                                   ` Thomas Monjalon
2014-09-10 15:09           ` Bruce Richardson
2014-09-10 15:31             ` Olivier MATZ
2014-09-03 15:49   ` [PATCH 08/13] mbuf: add named points inside the mbuf structure Bruce Richardson
     [not found]     ` <1409759378-10113-9-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-08 12:08       ` Olivier MATZ
2014-09-03 15:49   ` [PATCH 09/13] ixgbe: rework vector pmd following mbuf changes Bruce Richardson
2014-09-03 15:49   ` [PATCH 10/13] mbuf: split mbuf across two cache lines Bruce Richardson
     [not found]     ` <1409759378-10113-11-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-08 12:10       ` Olivier MATZ
2014-09-03 15:49   ` [PATCH 11/13] mbuf: move l2_len and l3_len to second cache line Bruce Richardson
     [not found]     ` <1409759378-10113-12-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-04  5:08       ` Yerden Zhumabekov
     [not found]         ` <20140904102744.GA23231@sivswdev02.ir.intel.com>
     [not found]           ` <20140904102744.GA23231-IWE99D/oH1/+pXziaqXtF9h3ngVCH38I@public.gmane.org>
2014-09-04 11:00             ` Yerden Zhumabekov
     [not found]               ` <5408463C.8040805-8EHiFRVJVgQ@public.gmane.org>
2014-09-04 11:55                 ` Bruce Richardson
2014-09-03 15:49   ` [PATCH 12/13] ixgbe: Fix perf regression due to moved pool ptr Bruce Richardson
2014-09-03 15:49   ` [PATCH 13/13] ixgbe: Improve slow-path perf: vector scattered RX Bruce Richardson
2014-09-11 13:15   ` [PATCH v2 00/13] Mbuf Structure Rework, part 2 Bruce Richardson
     [not found]     ` <1410441347-22840-1-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-11 13:15       ` [PATCH v2 01/13] mbuf: replace data pointer by an offset Bruce Richardson
2014-09-11 13:15       ` [PATCH v2 02/13] mbuf: reorder fields by time of use Bruce Richardson
     [not found]         ` <1410441347-22840-3-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-15  7:11           ` Liu, Jijiang
     [not found]             ` <1ED644BD7E0A5F4091CF203DAFB8E4CC01D701BA-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-09-15  8:19               ` Richardson, Bruce
2014-09-11 13:15       ` [PATCH v2 03/13] mbuf: expand ol_flags field to 64-bits Bruce Richardson
2014-09-11 13:15       ` Bruce Richardson [this message]
2014-09-11 13:15       ` [PATCH v2 05/13] mbuf: minor changes for readability Bruce Richardson
2014-09-11 13:15       ` [PATCH v2 06/13] mbuf: use macros only to access the mbuf metadata Bruce Richardson
2014-09-11 13:15       ` [PATCH v2 07/13] mbuf: move metadata macros to rte_port library Bruce Richardson
2014-09-11 13:15       ` [PATCH v2 08/13] mbuf: add named points inside the mbuf structure Bruce Richardson
2014-09-11 13:15       ` [PATCH v2 09/13] ixgbe: rework vector pmd following mbuf changes Bruce Richardson
2014-09-11 13:15       ` [PATCH v2 10/13] mbuf: split mbuf across two cache lines Bruce Richardson
2014-09-11 13:15       ` [PATCH v2 11/13] mbuf: move l2_len and l3_len to second cache line Bruce Richardson
2014-09-11 13:15       ` [PATCH v2 12/13] ixgbe: Fix perf regression due to moved pool ptr Bruce Richardson
     [not found]         ` <1410441347-22840-13-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-15 16:20           ` [PATCH v3 " Bruce Richardson
2014-09-11 13:15       ` [PATCH v2 13/13] ixgbe: Improve slow-path perf: vector scattered RX Bruce Richardson
2014-09-17 22:35       ` [PATCH v2 00/13] Mbuf Structure Rework, part 2 Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1410441347-22840-5-git-send-email-bruce.richardson@intel.com \
    --to=bruce.richardson-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).