* [PATCH] lib/librte_pmd_i40e: i40e vlan filter set fix
@ 2014-09-28 5:49 Huawei Xie
[not found] ` <1411883352-22166-1-git-send-email-huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Huawei Xie @ 2014-09-28 5:49 UTC (permalink / raw)
To: dev-VfR2kkLFssw
the right shift bits should be 5 rather than 4.
vid_idx = (uint32_t) ((vlan_id >> 5 ) & 0x7F)
Signed-off-by: Huawei Xie <huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
CC: Jing Chen <jing.d.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
CC: Helin Zhang <helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
lib/librte_pmd_i40e/i40e_ethdev.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c
index 9009bd4..9c9d831 100644
--- a/lib/librte_pmd_i40e/i40e_ethdev.c
+++ b/lib/librte_pmd_i40e/i40e_ethdev.c
@@ -3786,14 +3786,11 @@ i40e_set_vlan_filter(struct i40e_vsi *vsi,
{
uint32_t vid_idx, vid_bit;
-#define UINT32_BIT_MASK 0x1F
-#define VALID_VLAN_BIT_MASK 0xFFF
/* VFTA is 32-bits size array, each element contains 32 vlan bits, Find the
* element first, then find the bits it belongs to
*/
- vid_idx = (uint32_t) ((vlan_id & VALID_VLAN_BIT_MASK) >>
- sizeof(uint32_t));
- vid_bit = (uint32_t) (1 << (vlan_id & UINT32_BIT_MASK));
+ vid_idx = (uint32_t) ((vlan_id >> 5 ) & 0x7F);
+ vid_bit = (uint32_t) (1 << (vlan_id & 0x1F));
if (on)
vsi->vfta[vid_idx] |= vid_bit;
--
1.8.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread[parent not found: <1411883352-22166-1-git-send-email-huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH] lib/librte_pmd_i40e: i40e vlan filter set fix [not found] ` <1411883352-22166-1-git-send-email-huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> @ 2014-10-11 7:20 ` Chen, Jing D 2014-11-06 0:22 ` Xie, Huawei 1 sibling, 0 replies; 4+ messages in thread From: Chen, Jing D @ 2014-10-11 7:20 UTC (permalink / raw) To: Xie, Huawei, dev-VfR2kkLFssw@public.gmane.org > -----Original Message----- > From: Xie, Huawei > Sent: Sunday, September 28, 2014 1:49 PM > To: dev-VfR2kkLFssw@public.gmane.org > Cc: Xie, Huawei; Chen, Jing D; Zhang, Helin > Subject: [PATCH] lib/librte_pmd_i40e: i40e vlan filter set fix > > the right shift bits should be 5 rather than 4. > vid_idx = (uint32_t) ((vlan_id >> 5 ) & 0x7F) > > Signed-off-by: Huawei Xie <huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> > CC: Jing Chen <jing.d.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> > CC: Helin Zhang <helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> > > --- > lib/librte_pmd_i40e/i40e_ethdev.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c > b/lib/librte_pmd_i40e/i40e_ethdev.c > index 9009bd4..9c9d831 100644 > --- a/lib/librte_pmd_i40e/i40e_ethdev.c > +++ b/lib/librte_pmd_i40e/i40e_ethdev.c > @@ -3786,14 +3786,11 @@ i40e_set_vlan_filter(struct i40e_vsi *vsi, > { > uint32_t vid_idx, vid_bit; > > -#define UINT32_BIT_MASK 0x1F > -#define VALID_VLAN_BIT_MASK 0xFFF > /* VFTA is 32-bits size array, each element contains 32 vlan bits, Find > the > * element first, then find the bits it belongs to > */ > - vid_idx = (uint32_t) ((vlan_id & VALID_VLAN_BIT_MASK) >> > - sizeof(uint32_t)); > - vid_bit = (uint32_t) (1 << (vlan_id & UINT32_BIT_MASK)); > + vid_idx = (uint32_t) ((vlan_id >> 5 ) & 0x7F); > + vid_bit = (uint32_t) (1 << (vlan_id & 0x1F)); > > if (on) > vsi->vfta[vid_idx] |= vid_bit; > -- > 1.8.1.4 Please try to use macro to replace numbers. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] lib/librte_pmd_i40e: i40e vlan filter set fix [not found] ` <1411883352-22166-1-git-send-email-huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> 2014-10-11 7:20 ` Chen, Jing D @ 2014-11-06 0:22 ` Xie, Huawei [not found] ` <C37D651A908B024F974696C65296B57B0F2E2766-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org> 1 sibling, 1 reply; 4+ messages in thread From: Xie, Huawei @ 2014-11-06 0:22 UTC (permalink / raw) To: dev-VfR2kkLFssw@public.gmane.org Thomas, comments for this patch? > -----Original Message----- > From: Xie, Huawei > Sent: Saturday, September 27, 2014 10:49 PM > To: dev-VfR2kkLFssw@public.gmane.org > Cc: Xie, Huawei; Chen, Jing D; Zhang, Helin > Subject: [PATCH] lib/librte_pmd_i40e: i40e vlan filter set fix > > the right shift bits should be 5 rather than 4. > vid_idx = (uint32_t) ((vlan_id >> 5 ) & 0x7F) > > Signed-off-by: Huawei Xie <huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> > CC: Jing Chen <jing.d.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> > CC: Helin Zhang <helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> > > --- > lib/librte_pmd_i40e/i40e_ethdev.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c > b/lib/librte_pmd_i40e/i40e_ethdev.c > index 9009bd4..9c9d831 100644 > --- a/lib/librte_pmd_i40e/i40e_ethdev.c > +++ b/lib/librte_pmd_i40e/i40e_ethdev.c > @@ -3786,14 +3786,11 @@ i40e_set_vlan_filter(struct i40e_vsi *vsi, > { > uint32_t vid_idx, vid_bit; > > -#define UINT32_BIT_MASK 0x1F > -#define VALID_VLAN_BIT_MASK 0xFFF > /* VFTA is 32-bits size array, each element contains 32 vlan bits, Find the > * element first, then find the bits it belongs to > */ > - vid_idx = (uint32_t) ((vlan_id & VALID_VLAN_BIT_MASK) >> > - sizeof(uint32_t)); > - vid_bit = (uint32_t) (1 << (vlan_id & UINT32_BIT_MASK)); > + vid_idx = (uint32_t) ((vlan_id >> 5 ) & 0x7F); > + vid_bit = (uint32_t) (1 << (vlan_id & 0x1F)); > > if (on) > vsi->vfta[vid_idx] |= vid_bit; > -- > 1.8.1.4 ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <C37D651A908B024F974696C65296B57B0F2E2766-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>]
* Re: [PATCH] lib/librte_pmd_i40e: i40e vlan filter set fix [not found] ` <C37D651A908B024F974696C65296B57B0F2E2766-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org> @ 2014-11-06 8:37 ` Thomas Monjalon 0 siblings, 0 replies; 4+ messages in thread From: Thomas Monjalon @ 2014-11-06 8:37 UTC (permalink / raw) To: Xie, Huawei; +Cc: dev-VfR2kkLFssw 2014-11-06 00:22, Xie, Huawei: > Thomas, comments for this patch? No, but Jing Chen made some comments that you didn't replied: "Please try to use macro to replace numbers." So I wait a v2. > > -----Original Message----- > > From: Xie, Huawei > > Sent: Saturday, September 27, 2014 10:49 PM > > To: dev-VfR2kkLFssw@public.gmane.org > > Cc: Xie, Huawei; Chen, Jing D; Zhang, Helin > > Subject: [PATCH] lib/librte_pmd_i40e: i40e vlan filter set fix > > > > the right shift bits should be 5 rather than 4. > > vid_idx = (uint32_t) ((vlan_id >> 5 ) & 0x7F) > > > > Signed-off-by: Huawei Xie <huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> > > CC: Jing Chen <jing.d.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> > > CC: Helin Zhang <helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> > > > > --- > > lib/librte_pmd_i40e/i40e_ethdev.c | 7 ++----- > > 1 file changed, 2 insertions(+), 5 deletions(-) > > > > diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c > > b/lib/librte_pmd_i40e/i40e_ethdev.c > > index 9009bd4..9c9d831 100644 > > --- a/lib/librte_pmd_i40e/i40e_ethdev.c > > +++ b/lib/librte_pmd_i40e/i40e_ethdev.c > > @@ -3786,14 +3786,11 @@ i40e_set_vlan_filter(struct i40e_vsi *vsi, > > { > > uint32_t vid_idx, vid_bit; > > > > -#define UINT32_BIT_MASK 0x1F > > -#define VALID_VLAN_BIT_MASK 0xFFF > > /* VFTA is 32-bits size array, each element contains 32 vlan bits, Find the > > * element first, then find the bits it belongs to > > */ > > - vid_idx = (uint32_t) ((vlan_id & VALID_VLAN_BIT_MASK) >> > > - sizeof(uint32_t)); > > - vid_bit = (uint32_t) (1 << (vlan_id & UINT32_BIT_MASK)); > > + vid_idx = (uint32_t) ((vlan_id >> 5 ) & 0x7F); > > + vid_bit = (uint32_t) (1 << (vlan_id & 0x1F)); > > > > if (on) > > vsi->vfta[vid_idx] |= vid_bit; > > -- > > 1.8.1.4 ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-11-06 8:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-28 5:49 [PATCH] lib/librte_pmd_i40e: i40e vlan filter set fix Huawei Xie
[not found] ` <1411883352-22166-1-git-send-email-huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-10-11 7:20 ` Chen, Jing D
2014-11-06 0:22 ` Xie, Huawei
[not found] ` <C37D651A908B024F974696C65296B57B0F2E2766-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-11-06 8:37 ` Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).