dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
From: Sergio Gonzalez Monroy <sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: dev-VfR2kkLFssw@public.gmane.org
Subject: [PATCH v2 4/4] Link apps/DSOs against EXECENV_LDLIBS with --as-needed
Date: Mon,  6 Oct 2014 11:52:35 +0100	[thread overview]
Message-ID: <1412592755-3370-5-git-send-email-sergio.gonzalez.monroy@intel.com> (raw)
In-Reply-To: <1412592755-3370-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
 mk/rte.app.mk      | 4 ++--
 mk/rte.lib.mk      | 8 +++++++-
 mk/rte.sharelib.mk | 7 ++++++-
 3 files changed, 15 insertions(+), 4 deletions(-)

diff --git a/mk/rte.app.mk b/mk/rte.app.mk
index 5e00e67..e775ad7 100644
--- a/mk/rte.app.mk
+++ b/mk/rte.app.mk
@@ -62,9 +62,9 @@ ifeq ($(NO_AUTOLIBS),)
 LDLIBS += --whole-archive
 LDLIBS += -l$(RTE_LIBNAME)
 LDLIBS += --no-whole-archive
-LDLIBS += --start-group
+LDLIBS += --as-needed
 LDLIBS += $(EXECENV_LDLIBS)
-LDLIBS += --end-group
+LDLIBS += --no-as-needed
 
 endif # ifeq ($(NO_AUTOLIBS),)
 
diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk
index e7420bf..947e17d 100644
--- a/mk/rte.lib.mk
+++ b/mk/rte.lib.mk
@@ -59,14 +59,20 @@ build: _postbuild
 
 exe2cmd = $(strip $(call dotfile,$(patsubst %,%.cmd,$(1))))
 
+O_TO_S_LDLIBS := --as-needed
+O_TO_S_LDLIBS += $(EXECENV_LDLIBS)
+O_TO_S_LDLIBS += --no-as-needed
+
 ifeq ($(LINK_USING_CC),1)
 # Override the definition of LD here, since we're linking with CC
 LD := $(CC)
 LD_MULDEFS := $(call linkerprefix,-z$(comma)muldefs)
 CPU_LDFLAGS := $(call linkerprefix,$(CPU_LDFLAGS))
+O_TO_S_LDLIBS := $(call linkerprefix,$(O_TO_S_LDLIBS))
 endif
 
-O_TO_S = $(LD) $(CPU_LDFLAGS) $(LD_MULDEFS) -shared $(OBJS-y) -o $(LIB)
+O_TO_S = $(LD) $(CPU_LDFLAGS) $(LD_MULDEFS) -shared $(OBJS-y) \
+	$(O_TO_S_LDLIBS) -o $(LIB)
 O_TO_S_STR = $(subst ','\'',$(O_TO_S)) #') # fix syntax highlight
 O_TO_S_DISP = $(if $(V),"$(O_TO_S_STR)","  LD $(@)")
 O_TO_S_CMD = "cmd_$@ = $(O_TO_S_STR)"
diff --git a/mk/rte.sharelib.mk b/mk/rte.sharelib.mk
index 8fc6548..380aa7d 100644
--- a/mk/rte.sharelib.mk
+++ b/mk/rte.sharelib.mk
@@ -40,11 +40,16 @@ else
 LIB_ONE := lib$(RTE_LIBNAME).a
 endif
 
+O_TO_L_LDLIBS := --as-needed
+O_TO_L_LDLIBS += $(EXECENV_LDLIBS)
+O_TO_L_LDLIBS += --no-as-needed
+
 ifeq ($(LINK_USING_CC),1)
 # Override the definition of LD here, since we're linking with CC
 LD := $(CC)
 LD_MULDEFS := $(call linkerprefix,-z$(comma)muldefs)
 CPU_LDFLAGS := $(call linkerprefix,$(CPU_LDFLAGS))
+O_TO_L_LDLIBS := $(call linkerprefix,$(O_TO_L_LDLIBS))
 endif
 
 .PHONY:sharelib
@@ -54,7 +59,7 @@ OBJS = $(wildcard $(RTE_OUTPUT)/build/lib/*.o)
 
 ifeq ($(RTE_BUILD_SHARED_LIB),y)
 O_TO_L = $(LD) $(CPU_LDFLAGS) $(LD_MULDEFS) -shared $(OBJS)\
-	-o $(RTE_OUTPUT)/lib/$(LIB_ONE)
+	$(O_TO_L_LDLIBS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE)
 L_DISP=LD
 else
 O_TO_L = $(AR) crus $(RTE_OUTPUT)/lib/$(LIB_ONE) $(OBJS)
-- 
1.9.3

  parent reply	other threads:[~2014-10-06 10:52 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-02 15:56 [PATCH 0/4] Fix build issues with CONFIG_RTE_BUILD_COMBINE_LIBS=y Sergio Gonzalez Monroy
     [not found] ` <1412265386-26291-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-10-02 15:56   ` [PATCH 1/4] Link combined shared library using CC Sergio Gonzalez Monroy
2014-10-02 15:56   ` [PATCH 2/4] Do not generate individual libs when configured with RTE_BUILD_COMBINE_LIBS=y Sergio Gonzalez Monroy
     [not found]     ` <1412265386-26291-3-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-10-02 20:00       ` Matthew Hall
2014-10-02 15:56   ` [PATCH 3/4] Link apps only against combined lib or individual libs, not both Sergio Gonzalez Monroy
2014-10-02 15:56   ` [PATCH 4/4] Cleanup Sergio Gonzalez Monroy
2014-10-02 17:26   ` [PATCH 0/4] Fix build issues with CONFIG_RTE_BUILD_COMBINE_LIBS=y Neil Horman
     [not found]     ` <20141002172634.GE4900-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-10-02 20:04       ` Matthew Hall
     [not found]         ` <20141002200420.GB29590-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
2014-10-02 20:24           ` Neil Horman
     [not found]             ` <20141002202451.GF4900-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-10-02 21:10               ` Matthew Hall
     [not found]                 ` <20141002211055.GA30270-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
2014-10-03  0:52                   ` Neil Horman
2014-10-03 10:31               ` Sergio Gonzalez Monroy
     [not found]                 ` <20141003103110.GB28988-IWE99D/oH1/+pXziaqXtF9h3ngVCH38I@public.gmane.org>
2014-10-03 11:28                   ` Neil Horman
     [not found]                     ` <20141003112833.GA24059-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-10-03 23:52                       ` Stephen Hemminger
2014-10-04  2:30                         ` Neil Horman
2014-10-03  7:15           ` Thomas Monjalon
2014-10-03  8:10             ` Sergio Gonzalez Monroy
     [not found]               ` <20141003081019.GA28988-IWE99D/oH1/+pXziaqXtF9h3ngVCH38I@public.gmane.org>
2014-10-03  8:27                 ` Thomas Monjalon
2014-10-03 11:32                   ` Neil Horman
     [not found]                     ` <20141003113234.GB24059-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-10-03 18:17                       ` Matthew Hall
     [not found]                         ` <20141003181713.GC1741-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
2014-10-03 19:15                           ` Neil Horman
     [not found]                             ` <20141003191546.GD24059-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-10-03 21:21                               ` Matthew Hall
     [not found]                                 ` <20141003212150.GA2637-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
2014-10-06 14:45                                   ` Neil Horman
2014-10-03 18:13                   ` Matthew Hall
2014-10-03 18:00             ` Matthew Hall
2014-10-06 10:52   ` [PATCH v2 0/4] Update build process Sergio Gonzalez Monroy
     [not found]     ` <1412592755-3370-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-10-06 10:52       ` [PATCH v2 1/4] Link combined shared library using CC Sergio Gonzalez Monroy
2014-10-06 10:52       ` [PATCH v2 2/4] Link apps only against single/combined library Sergio Gonzalez Monroy
2014-10-06 10:52       ` [PATCH v2 3/4] Update library build process Sergio Gonzalez Monroy
     [not found]         ` <1412592755-3370-4-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-10-06 20:46           ` Matthew Hall
     [not found]             ` <20141006204607.GA18992-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
2014-10-07  9:55               ` Sergio Gonzalez Monroy
     [not found]                 ` <20141007095511.GA27326-IWE99D/oH1/+pXziaqXtF9h3ngVCH38I@public.gmane.org>
2014-10-08 22:36                   ` Matthew Hall
     [not found]                     ` <20141008223655.GB29243-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
2014-10-09  9:44                       ` Sergio Gonzalez Monroy
2014-10-08 15:38           ` Thomas Monjalon
2014-10-06 10:52       ` Sergio Gonzalez Monroy [this message]
     [not found]         ` <1412592755-3370-5-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-10-08 15:38           ` [PATCH v2 4/4] Link apps/DSOs against EXECENV_LDLIBS with --as-needed Thomas Monjalon
2014-10-09  9:23             ` Sergio Gonzalez Monroy
2014-10-06 14:49       ` [PATCH v2 0/4] Update build process Neil Horman
     [not found]         ` <20141006144946.GD22304-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-10-06 15:01           ` Sergio Gonzalez Monroy
     [not found]             ` <20141006150133.GA778-IWE99D/oH1/+pXziaqXtF9h3ngVCH38I@public.gmane.org>
2014-10-06 16:05               ` Neil Horman
2014-10-09 13:04       ` [PATCH v3 0/6] Update libs " Sergio Gonzalez Monroy
     [not found]         ` <1412859898-29068-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-10-09 13:04           ` [PATCH v3 1/6] Link combined shared library using CC Sergio Gonzalez Monroy
2014-10-09 13:04           ` [PATCH v3 2/6] Link apps only against single/combined library Sergio Gonzalez Monroy
2014-10-09 13:04           ` [PATCH v3 3/6] Remove CONFIG_RTE_BUILD_COMBINE_LIBS and related Sergio Gonzalez Monroy
2014-10-09 13:04           ` [PATCH v3 4/6] Update library build process Sergio Gonzalez Monroy
2014-10-09 13:04           ` [PATCH v3 5/6] Avoid duplicated code Sergio Gonzalez Monroy
2014-10-09 13:04           ` [PATCH v3 6/6] Link apps/DSOs against EXECENV_LDLIBS with --as-needed Sergio Gonzalez Monroy
2014-10-13 16:01           ` [PATCH v3 0/6] Update libs build process Gonzalez Monroy, Sergio
     [not found]             ` <91383E96CE459D47BCE92EFBF5CE73B0C7E2B6-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-10-21  9:43               ` Gonzalez Monroy, Sergio
     [not found]                 ` <91383E96CE459D47BCE92EFBF5CE73B0C7F7E6-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-10-22 16:14                   ` Gonzalez Monroy, Sergio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1412592755-3370-5-git-send-email-sergio.gonzalez.monroy@intel.com \
    --to=sergio.gonzalez.monroy-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).