From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 4/4] net/failsafe: support secondary process Date: Tue, 05 Mar 2019 11:00:50 +0100 Message-ID: <14127814.HFQHTULaMT@xps> References: <1551368952-1871-1-git-send-email-rasland@mellanox.com> <20190228092434.20685ac8@shemminger-XPS-13-9360> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Stephen Hemminger , "gaetan.rivet@6wind.com" , "dev@dpdk.org" To: Raslan Darawsheh Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 349842BA7 for ; Tue, 5 Mar 2019 11:00:54 +0100 (CET) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/03/2019 10:33, Raslan Darawsheh: > Hi Stephen, > > From: Stephen Hemminger > > On Thu, 28 Feb 2019 15:49:28 +0000 > > Raslan Darawsheh wrote: > > > > > + eth_dev->rx_pkt_burst = > > (eth_rx_burst_t)&failsafe_rx_burst; > > > + eth_dev->tx_pkt_burst = > > (eth_tx_burst_t)&failsafe_tx_burst; > > > > Why is cast necessary here. The function signature should match. > > I don't think it's necessary, but this is the same as the primary process implementation If it's not necessary, better to not add them. Don't worry about consistency for pointer casting :)