From: Yong Wang <yongwang-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
To: dev-VfR2kkLFssw@public.gmane.org
Subject: [PATCH 1/5] vmxnet3: Fix VLAN Rx stripping
Date: Sun, 12 Oct 2014 23:23:05 -0700 [thread overview]
Message-ID: <1413181389-14887-2-git-send-email-yongwang@vmware.com> (raw)
In-Reply-To: <1413181389-14887-1-git-send-email-yongwang-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
Shouldn't reset vlan_tci to 0 if a valid VLAN tag is stripped.
Signed-off-by: Yong Wang <yongwang-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
---
lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c
index 263f9ce..986e5e5 100644
--- a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c
+++ b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c
@@ -540,21 +540,19 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
/* Check for hardware stripped VLAN tag */
if (rcd->ts) {
-
PMD_RX_LOG(ERR, "Received packet with vlan ID: %d.",
rcd->tci);
rxm->ol_flags = PKT_RX_VLAN_PKT;
-
#ifdef RTE_LIBRTE_VMXNET3_DEBUG_DRIVER
VMXNET3_ASSERT(rxm &&
rte_pktmbuf_mtod(rxm, void *));
#endif
/* Copy vlan tag in packet buffer */
- rxm->vlan_tci = rte_le_to_cpu_16(
- (uint16_t)rcd->tci);
-
- } else
+ rxm->vlan_tci = rte_le_to_cpu_16((uint16_t)rcd->tci);
+ } else {
rxm->ol_flags = 0;
+ rxm->vlan_tci = 0;
+ }
/* Initialize newly received packet buffer */
rxm->port = rxq->port_id;
@@ -563,11 +561,9 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
rxm->pkt_len = (uint16_t)rcd->len;
rxm->data_len = (uint16_t)rcd->len;
rxm->port = rxq->port_id;
- rxm->vlan_tci = 0;
rxm->data_off = RTE_PKTMBUF_HEADROOM;
rx_pkts[nb_rx++] = rxm;
-
rcd_done:
rxq->cmd_ring[ring_idx].next2comp = idx;
VMXNET3_INC_RING_IDX_ONLY(rxq->cmd_ring[ring_idx].next2comp, rxq->cmd_ring[ring_idx].size);
--
1.9.1
next prev parent reply other threads:[~2014-10-13 6:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-13 6:23 [PATCH 0/5] vmxnet3 pmd fixes/improvement Yong Wang
[not found] ` <1413181389-14887-1-git-send-email-yongwang-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2014-10-13 6:23 ` Yong Wang [this message]
[not found] ` <1413181389-14887-2-git-send-email-yongwang-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2014-10-13 9:31 ` [PATCH 1/5] vmxnet3: Fix VLAN Rx stripping Stephen Hemminger
[not found] ` <20141013113146.202b5eb3-CA4OZQ/Yy2Lykuyl+CZolw@public.gmane.org>
2014-10-13 18:42 ` Yong Wang
[not found] ` <eb7d95c060e940c3bebea3612b9d9b33-kzjMWN3NnNA9Xh8A42242iWTkRzJkiQl@public.gmane.org>
2014-10-22 13:39 ` Stephen Hemminger
[not found] ` <20141022190933.44549786-CA4OZQ/Yy2Lykuyl+CZolw@public.gmane.org>
2014-10-28 21:57 ` Yong Wang
[not found] ` <D07558ED.2308C%yongwang-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2014-10-29 9:04 ` Bruce Richardson
2014-10-29 9:41 ` Thomas Monjalon
2014-10-29 17:57 ` Yong Wang
[not found] ` <D07677ED.23355%yongwang-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2014-10-29 18:51 ` Thomas Monjalon
2014-10-13 6:23 ` [PATCH 2/5] vmxnet3: Add VLAN Tx offload Yong Wang
2014-10-13 6:23 ` [PATCH 3/5] vmxnet3: Fix dev stop/restart bug Yong Wang
2014-10-13 6:23 ` [PATCH 4/5] vmxnet3: Add rx pkt check offloads Yong Wang
2014-10-13 6:23 ` [PATCH 5/5] vmxnet3: Some perf improvement on the rx path Yong Wang
[not found] ` <1413181389-14887-6-git-send-email-yongwang-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2014-11-05 0:13 ` Thomas Monjalon
2014-10-13 20:29 ` [PATCH 0/5] vmxnet3 pmd fixes/improvement Thomas Monjalon
2014-10-13 21:00 ` Yong Wang
[not found] ` <edc61efd1bbf4798ac333a979405ed8b-kzjMWN3NnNA9Xh8A42242iWTkRzJkiQl@public.gmane.org>
2014-10-21 22:10 ` Yong Wang
[not found] ` <1c9ce28892d24052b2a3636507f9dba7-kzjMWN3NnNA9Xh8A42242iWTkRzJkiQl@public.gmane.org>
2014-10-22 7:07 ` Cao, Waterman
[not found] ` <AA3F441F262C58498CD6D0C1801DE7EB0ABB1E18-0J0gbvR4kTggGBtAFL8yw7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-10-28 14:40 ` Thomas Monjalon
2014-10-28 19:59 ` Yong Wang
[not found] ` <d75dd42ad6b2465cbf86bb7a0c2dd445-kzjMWN3NnNA9Xh8A42242iWTkRzJkiQl@public.gmane.org>
2014-10-29 0:33 ` Cao, Waterman
2014-11-05 1:32 ` Cao, Waterman
2014-11-04 5:57 ` Zhang, XiaonanX
[not found] ` <63FB47D6C0357E428AA804B2C89068BA0125D18B-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-11-04 22:50 ` Thomas Monjalon
2014-11-05 5:26 ` Cao, Waterman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413181389-14887-2-git-send-email-yongwang@vmware.com \
--to=yongwang-pghwnbhtmq7qt0dzr+alfa@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).