From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v7 3/5] ethdev: redesign link speed config API Date: Fri, 29 Jan 2016 10:53:47 +0100 Message-ID: <14139435.dXsMv1AF6J@xps13> References: <1445810400-8978-1-git-send-email-marcdevel@gmail.com> <1745156.01DTmyzyO8@xps13> <2601191342CEEE43887BDE71AB97725836B000EC@irsmsx105.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: "dev@dpdk.org" To: "Ananyev, Konstantin" Return-path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 97A3BC5CC for ; Fri, 29 Jan 2016 10:55:00 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id l66so46842966wml.0 for ; Fri, 29 Jan 2016 01:55:00 -0800 (PST) In-Reply-To: <2601191342CEEE43887BDE71AB97725836B000EC@irsmsx105.ger.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-01-29 09:47, Ananyev, Konstantin: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2016-01-29 09:24, Ananyev, Konstantin: > > > Can you avoid modifications in the e1000/base code? > > > We do not modify (and maintain) that part on our own. > > > Instead we take it straight from Intel ND. > > > So if you feel like these changes are really necessary - please submit a patch > > > to ND first, and if your changes will be applied, will pick it up from them. > > > > I was not aware we can submit a change to ND for Intel base drivers. > > What is the procedure please? > > I meant not to the ND directly, but probably to the freebsd e1000 kernel driver. > As I remember, that is the closest one to what we have. > From my understanding (I might be wrong here): > If they will be accepted, we should see these changes In next code drops from ND. These base drivers are used in several places. We are allowed to submit a patch in Linux or FreeBSD but not in DPDK where the base driver is verbatim? We have an agreement to not touch them in DPDK but I still think the ND team could consider some patches from dpdk.org.