From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chao Zhu Subject: [PATCH v3 13/14] test_memzone:fix finding the second smallest segment Date: Sun, 23 Nov 2014 20:22:21 -0500 Message-ID: <1416792142-23132-14-git-send-email-chaozhu@linux.vnet.ibm.com> References: <1416792142-23132-1-git-send-email-chaozhu@linux.vnet.ibm.com> To: dev-VfR2kkLFssw@public.gmane.org Return-path: In-Reply-To: <1416792142-23132-1-git-send-email-chaozhu-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Curent implementation in test_memzone.c has bugs in finding the second smallest memory segment. It's the last smallest memory segment, but it's not the second smallest memory segment. This bug may cause test failure in some cases. This patch fixes this bug. Signed-off-by: Chao Zhu --- app/test/test_memzone.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test/test_memzone.c b/app/test/test_memzone.c index 8668103..f3da2c1 100644 --- a/app/test/test_memzone.c +++ b/app/test/test_memzone.c @@ -794,7 +794,7 @@ test_memzone_reserve_memory_in_smallest_segment(void) /* set new smallest */ min_ms = ms; } - else if (prev_min_ms == NULL) { + else if ((prev_min_ms == NULL) || (prev_min_ms->len > ms->len)) { prev_min_ms = ms; } } @@ -874,7 +874,7 @@ test_memzone_reserve_memory_with_smallest_offset(void) /* set new smallest */ min_ms = ms; } - else if (prev_min_ms == NULL) { + else if ((prev_min_ms == NULL) || (prev_min_ms->len > ms->len)){ prev_min_ms = ms; } } -- 1.7.1