From mboxrd@z Thu Jan 1 00:00:00 1970 From: chixiaobo Subject: [PATCH v2] add one option memory-only for secondary processes Date: Wed, 3 Dec 2014 18:11:58 +0800 Message-ID: <1417601518-16852-1-git-send-email-xiaobo.chi@nsn.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable To: dev-VfR2kkLFssw@public.gmane.org Return-path: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" From: Chi Xiaobo Problem: There is one normal DPDK processes deployment scenarios: one pri= mary process and several (even hundreds) secondary processes; all outside= packets/messages are sent/received by primary process and then distribut= e them to those secondary processes by DPDK's ring/sharedmemory mechanism= . In such scenarios, those SECONDARY processes need only hugepage based s= harememory mechanism and it?=A1=A5s upper libs (such as ring, mempool, et= c.), they need not cpu core pinning, iopl privilege changing , pci device= , timer, alarm, interrupt, shared_driver_list, core_info, threads for ea= ch core, etc. Then, for such kind of SECONDARY processes, the current rte= _eal_init() is too heavy. Solution:One new EAL initializing argument, --memory-only, is added. It i= s only for those SECONDARY processes which only want to share memory with= other processes. if this argument is defined, users need not define thos= e mandatory arguments, such as -c and -n, due to we don't want to pin suc= h kind of processes to any CPUs. Signed-off-by: Chi Xiaobo --- lib/librte_eal/common/eal_common_options.c | 17 ++++++++++++--- lib/librte_eal/common/eal_internal_cfg.h | 1 + lib/librte_eal/common/eal_options.h | 2 ++ lib/librte_eal/linuxapp/eal/eal.c | 34 +++++++++++++++++-------= ------ 4 files changed, 36 insertions(+), 18 deletions(-) diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/= common/eal_common_options.c index e2810ab..7b18498 100644 --- a/lib/librte_eal/common/eal_common_options.c +++ b/lib/librte_eal/common/eal_common_options.c @@ -85,6 +85,7 @@ eal_long_options[] =3D { {OPT_XEN_DOM0, 0, 0, OPT_XEN_DOM0_NUM}, {OPT_CREATE_UIO_DEV, 1, NULL, OPT_CREATE_UIO_DEV_NUM}, {OPT_VFIO_INTR, 1, NULL, OPT_VFIO_INTR_NUM}, + {OPT_MEMORY_ONLY, 0, NULL, OPT_MEMORY_ONLY_NUM}, {0, 0, 0, 0} }; =20 @@ -126,6 +127,7 @@ eal_reset_internal_config(struct internal_config *int= ernal_cfg) internal_cfg->no_hpet =3D 1; #endif internal_cfg->vmware_tsc_map =3D 0; + internal_cfg->memory_only=3D 0; } =20 /* @@ -454,6 +456,10 @@ eal_parse_common_option(int opt, const char *optarg, conf->process_type =3D eal_parse_proc_type(optarg); break; =20 + case OPT_MEMORY_ONLY_NUM: + conf->memory_only=3D 1; + break; + case OPT_MASTER_LCORE_NUM: if (eal_parse_master_lcore(optarg) < 0) { RTE_LOG(ERR, EAL, "invalid parameter for --" @@ -525,9 +531,9 @@ eal_check_common_options(struct internal_config *inte= rnal_cfg) { struct rte_config *cfg =3D rte_eal_get_configuration(); =20 - if (!lcores_parsed) { - RTE_LOG(ERR, EAL, "CPU cores must be enabled with options " - "-c or -l\n"); + if (!lcores_parsed && !(internal_cfg->process_type =3D=3D RTE_PROC_SECO= NDARY&& internal_cfg->memory_only) ) { + RTE_LOG(ERR, EAL, "For those processes without memory-only option, CPU= cores " + "must be enabled with options -c or -l\n"); return -1; } if (cfg->lcore_role[cfg->master_lcore] !=3D ROLE_RTE) { @@ -545,6 +551,10 @@ eal_check_common_options(struct internal_config *int= ernal_cfg) "specified\n"); return -1; } + if ( internal_cfg->process_type !=3D RTE_PROC_SECONDARY && internal_cfg= ->memory_only ) { + RTE_LOG(ERR, EAL, "only secondary processes can specify memory-only op= tion.\n"); + return -1; + } if (index(internal_cfg->hugefile_prefix, '%') !=3D NULL) { RTE_LOG(ERR, EAL, "Invalid char, '%%', in --"OPT_FILE_PREFIX" " "option\n"); @@ -590,6 +600,7 @@ eal_common_usage(void) " --"OPT_SYSLOG" : set syslog facility\n" " --"OPT_LOG_LEVEL" : set default log level\n" " --"OPT_PROC_TYPE" : type of this process\n" + " --"OPT_MEMORY_ONLY": only use shared memory, valid only for s= econdary process.\n" " --"OPT_PCI_BLACKLIST", -b: add a PCI device in black list.\n" " Prevent EAL from using this PCI device. The argu= ment\n" " format is .\n" diff --git a/lib/librte_eal/common/eal_internal_cfg.h b/lib/librte_eal/co= mmon/eal_internal_cfg.h index aac6abf..f51f0a2 100644 --- a/lib/librte_eal/common/eal_internal_cfg.h +++ b/lib/librte_eal/common/eal_internal_cfg.h @@ -85,6 +85,7 @@ struct internal_config { =20 unsigned num_hugepage_sizes; /**< how many sizes on this system */ struct hugepage_info hugepage_info[MAX_HUGEPAGE_SIZES]; + volatile unsigned memory_only; /**name); solib->lib_handle =3D dlopen(solib->name, RTLD_NOW); --=20 1.9.4.msysgit.2