From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jincheng Miao Subject: [PATCH v4 0/4] compatibility fallback and replacement of kernel function invoking Date: Wed, 10 Dec 2014 19:03:59 +0800 Message-ID: <1418209443-1744-1-git-send-email-jmiao@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable To: dev-VfR2kkLFssw@public.gmane.org Return-path: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" The related kernel function is: - pci_num_vf, it is introduced from upstream linux-2.6.34. For RHEL-based kernel, it is defined from RHEL5.9. - kstrtoul, this function is united kernel API to replace strict_strtoul = in the furture. It is introduced from linux-2.6.39. For RHEL6, it is defined from RHEL6.4. This patchset do some compatiblity work for these two functions, and replace strict_strtoul which is depleted from linux-3.18. Some test results for dpdk-1.8.0-rc3 with this patchset: 1. In RHEL7 GA: Build success after specify -mssse3 to CFLAGS, ``` CC ixgbe_rxtx_vec.o In file included from /root/dpdk-source/lib/librte_pmd_ixgbe/ixgbe_rxtx_v= ec.c:41:0: /usr/lib/gcc/x86_64-redhat-linux/4.8.2/include/tmmintrin.h:31:3: error: #= error "SSSE3 instruction set not enabled" # error "SSSE3 instruction set not enabled" ``` - for igb_uio, pass - for kni, pass - for xen_dom0, pass 2. In RHEL6.5 : Build fails for kni, and xen_dom0: - for igb_uio: pass - for kni: fail, the log is: ``` CC [M] /root/dpdk-source/build/build/lib/librte_eal/linuxapp/kni/kni_vhos= t.o /root/dpdk-source/build/build/lib/librte_eal/linuxapp/kni/kni_vhost.c: In= function =E2=80=98kni_sock_poll=E2=80=99: /root/dpdk-source/build/build/lib/librte_eal/linuxapp/kni/kni_vhost.c:222= : error: =E2=80=98struct socket=E2=80=99 has no member named =E2=80=98wq=E2= =80=99 /root/dpdk-source/build/build/lib/librte_eal/linuxapp/kni/kni_vhost.c: In= function =E2=80=98kni_chk_vhost_rx=E2=80=99: /root/dpdk-source/build/build/lib/librte_eal/linuxapp/kni/kni_vhost.c:313= : error: implicit declaration of function =E2=80=98sk_sleep=E2=80=99 cc1: warnings being treated as errors /root/dpdk-source/build/build/lib/librte_eal/linuxapp/kni/kni_vhost.c:313= : error: passing argument 1 of =E2=80=98__wake_up=E2=80=99 makes pointer = from integer without a cast include/linux/wait.h:146: note: expected =E2=80=98struct wait_queue_head_= t *=E2=80=99 but argument is of type =E2=80=98int=E2=80=99 /root/dpdk-source/build/build/lib/librte_eal/linuxapp/kni/kni_vhost.c: In= function =E2=80=98kni_sk_write_space=E2=80=99: /root/dpdk-source/build/build/lib/librte_eal/linuxapp/kni/kni_vhost.c:580= : error: assignment makes pointer from integer without a cast make[8]: *** [/root/dpdk-source/build/build/lib/librte_eal/linuxapp/kni/k= ni_vhost.o] Error 1 ``` - for xen_dom0: fail, seems xen is not offical supported in RHEL6. v4: Indent for patches. Include compat.h for kni_vhost.c v3: Adjust pci_num_vf() introduced RHEL version number. Seperate "replace strict_strtoul with kstrtoul" into 3 patches for igb_= uio, kni, and xen_dom0. Add compat.h in kni and xen_dom0 for compatible with older kernels. v2: Merge these two patch in one patchset. Compatible with old kernel for kstrtoul. Compatible with RHEL6 for pci_num_vf. Jincheng Miao (4): igb_uio: compatible with upstream longterm kernel and RHEL igb_uio: replace strict_strtoul with kstrtoul kni: replace strict_strtoul with kstrtoul xen_dom0: replace strict_strtoul with kstrtoul lib/librte_eal/linuxapp/igb_uio/compat.h | 11 ++++++++++- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 4 ++-- lib/librte_eal/linuxapp/kni/compat.h | 16 ++++++++++++++++ lib/librte_eal/linuxapp/kni/kni_vhost.c | 3 ++- lib/librte_eal/linuxapp/xen_dom0/compat.h | 16 ++++++++++++++++ lib/librte_eal/linuxapp/xen_dom0/dom0_mm_misc.c | 2 +- 6 files changed, 47 insertions(+), 5 deletions(-) create mode 100644 lib/librte_eal/linuxapp/kni/compat.h create mode 100644 lib/librte_eal/linuxapp/xen_dom0/compat.h --=20 1.8.3.1